-
Notifications
You must be signed in to change notification settings - Fork 2
Cats io support #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stankoua
wants to merge
3
commits into
master
Choose a base branch
from
task/cats-io-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cats io support #26
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 0 additions & 47 deletions
47
core/src/main/scala/core/database/ComposeWithCompletion.scala
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package com.zengularity.querymonad.core.database | ||
|
||
// import scala.concurrent.{ExecutionContext, Future} | ||
import scala.language.higherKinds | ||
|
||
/** | ||
* Heavily inspired from work done by @cchantep in Acolyte (see acolyte.reactivemongo.ComposeWithCompletion) | ||
*/ | ||
trait LiftAsync[F[_], M[_], A] { | ||
type Outer | ||
|
||
def apply[Resource]( | ||
loaner: WithResource[F, Resource], | ||
f: Resource => M[A] | ||
): F[Outer] | ||
} | ||
|
||
object LiftAsync { | ||
|
||
type Aux[F[_], M[_], A, B] = LiftAsync[F, M, A] { type Outer = B } | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,28 @@ | ||
package com.zengularity.querymonad.core.database | ||
|
||
import scala.concurrent.Future | ||
import scala.language.higherKinds | ||
|
||
/** | ||
* A class who can run a Query. | ||
*/ | ||
sealed trait QueryRunner[Resource] { | ||
sealed trait QueryRunner[F[_], Resource] { | ||
def apply[M[_], T](query: QueryT[M, Resource, T])( | ||
implicit compose: ComposeWithCompletion[M, T] | ||
): Future[compose.Outer] | ||
implicit lift: LiftAsync[F, M, T] | ||
): F[lift.Outer] | ||
} | ||
|
||
object QueryRunner { | ||
private class DefaultRunner[Resource](wr: WithResource[Resource]) | ||
extends QueryRunner[Resource] { | ||
private class DefaultRunner[F[_], Resource](wr: WithResource[F, Resource]) | ||
extends QueryRunner[F, Resource] { | ||
def apply[M[_], T]( | ||
query: QueryT[M, Resource, T] | ||
)(implicit compose: ComposeWithCompletion[M, T]): Future[compose.Outer] = | ||
compose(wr, query.run) | ||
)(implicit lift: LiftAsync[F, M, T]): F[lift.Outer] = | ||
lift(wr, query.run) | ||
} | ||
|
||
// Default factory | ||
def apply[Resource]( | ||
wr: WithResource[Resource] | ||
): QueryRunner[Resource] = | ||
def apply[F[_], Resource]( | ||
wr: WithResource[F, Resource] | ||
): QueryRunner[F, Resource] = | ||
new DefaultRunner(wr) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
package com.zengularity.querymonad.core.database | ||
|
||
import scala.concurrent.Future | ||
// import scala.concurrent.Future | ||
import scala.language.higherKinds | ||
|
||
trait WithResource[Resource] { | ||
def apply[A](f: Resource => Future[A]): Future[A] | ||
trait WithResource[F[_], Resource] { | ||
def apply[A](f: Resource => F[A]): F[A] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.zengularity.querymonad.module.future | ||
|
||
import scala.concurrent.{ExecutionContext, Future} | ||
import scala.language.higherKinds | ||
|
||
import com.zengularity.querymonad.core.database.LiftAsync | ||
|
||
trait LiftAsyncFuture extends LowPriority { | ||
|
||
implicit def futureOut[A]: LiftAsync.Aux[Future, Future, A, A] = | ||
new LiftAsync[Future, Future, A] { | ||
type Outer = A | ||
|
||
def apply[In]( | ||
loaner: WithResourceF[In], | ||
f: In => Future[A] | ||
): Future[Outer] = loaner(f) | ||
|
||
override val toString = "futureOut" | ||
} | ||
|
||
} | ||
|
||
trait LowPriority { _: LiftAsyncFuture => | ||
|
||
implicit def pureOut[F[_], A]( | ||
implicit ec: ExecutionContext | ||
): LiftAsync.Aux[Future, F, A, F[A]] = | ||
new LiftAsync[Future, F, A] { | ||
type Outer = F[A] | ||
|
||
def apply[In](loaner: WithResourceF[In], f: In => F[A]): Future[Outer] = | ||
loaner(r => Future(f(r))) | ||
|
||
override val toString = "pureOut" | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.zengularity.querymonad.module | ||
|
||
import scala.concurrent.Future | ||
|
||
import com.zengularity.querymonad.core.database.{QueryRunner, WithResource} | ||
|
||
package object future { | ||
|
||
type WithResourceF[Resource] = WithResource[Future, Resource] | ||
|
||
type QueryRunnerF[Resource] = QueryRunner[Future, Resource] | ||
|
||
object QueryRunnerF { | ||
def apply[Resource](wc: WithResourceF[Resource]): QueryRunnerF[Resource] = | ||
QueryRunnerF[Resource](wc) | ||
} | ||
|
||
object implicits extends LiftAsyncFuture | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantic is always async ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes (but no in term of
cats-effect
'sAsync
typeclass), since the essence of this typeclass is to wrap the computation in an async context (Future
orIO
). Maybe it can be confusing, so feel free to suggest any name which could express it better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task
?Effect
?