simplelink: Fix clang-llvm compiler errors/warnings #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inline assembly issues related to clang/llvm. Mostly related
errors of the form:
driverlib/cpu.h:373:28: error: parameter references not allowed in
naked functions
or
driverlib/cpu.c:253:5: error: non-ASM statement in naked function is
not supported
Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
|
Not being an expert in ARM assembly, I compared your changes to the corresponding files in TI SimpleLink SDK 3.40.00.02 which has clang support (see attached). The changes look close enough to me - maybe you will find a few more things you wish to copy over, if you haven't seen these files already. In the medium term I have it on my todo list to upgrade to the latest SDK so that we can take advantage of fixes such as these. |
|
@vaishnavachath - PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inline assembly issues related to clang/llvm. Mostly related
errors of the form:
driverlib/cpu.h:373:28: error: parameter references not allowed in
naked functions
or
driverlib/cpu.c:253:5: error: non-ASM statement in naked function is
not supported
Signed-off-by: Kumar Gala kumar.gala@linaro.org