zephyr: include: sof: trace: Fix the trace level setting #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses arch_cpu_start() instead of arch_start_cpu() as it has been renamed to align with the CPU namespace. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This changes the seconday core power up routine to use the newly introduced k_smp_cpu_start() and k_smp_cpu_resume(). This removes the need to mirror part of the SMP start up code from Zephyr, and no longer need to call into Zephyr private kernel code. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
nxp_adsp_imx8ulp needs to be in allowed platforms. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Use direct call to function instead of going over a redefine. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Set min. cmake version required to what zephyr uses. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Author
|
fyi @lgirdwood |
Header has a guard to not reinclude logging header if it was already included but inside this guard there is a definition of SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation fails. Moving this definition outside of the guard because if log.h is already included LOG_LEVEL_INF is available. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
fix_trace_h
branch
from
3c057d5 to
bb4f163
Compare
Author
|
How can I move it forward? @nashif can you help? |
Author
|
@nashif @lgirdwood ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header has a guard to not reinclude logging header if it was already included but inside this guard there is a definition of SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation fails.
Moving this definition outside of the guard because if log.h is already included LOG_LEVEL_INF is available.