platform: ext: common: template: Fix FOTA upgrade #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 31755 changes modified profile_definition from 32 to 48 bytes in the platform/ext/common/template/flash_otp_nv_counters_backend.h file. This change moved fields that are necessary to perform a an image upgrade. The issue is visible only when upgrading from an old image (without the changes) to a new one or vice versa. This means that TF-M 2.1.1 do not allow upgrade/downgrade to TF-M 2.2.0 or newer. This revert the change to allow migration from Zephyr 3.7.1 LTS to newer images like 4.2.0. More details from the change can be visualized in: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/31755 Signed-off-by: BUDKE Gerson Fernando <gerson.budke@leica-geosystems.com>
|
Indeed this change makes sense to have FW update compatible with previous release of immutable BL2. Since recent TF-M moves to this new field size, maybe it would be worth to have a configuration option to allow selecting the older or newer field size. |
|
Hi @etienne-lms ,
I'm waiting the outcome of https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/42130. I recommend someone from ST take a look on it. |
|
Closing this in favor of #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trusted-firmware-m/31755 changes modified
profile_definitionfrom 32 to 48 bytes in the platform/ext/common/template/flash_otp_nv_counters_backend.h file.This change moved fields that are necessary to perform an image upgrade. The issue is visible only when upgrading from an old image (without the changes) to a new one or vice versa. This means that TF-M 2.1.1 do not allow upgrade/downgrade to/from TF-M 2.2.0 or newer versions.
This revert the change to allow migration from Zephyr 3.7.1 LTS to newer images like 4.2.0.
More details from the change can be visualized in: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/31755
depends on https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/42130