Skip to content

Flash API: flash_mmap syscall allowing to obtain mapping of flash device in CPU address space #80525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Flash API: flash_mmap syscall allowing to obtain mapping of flash device in CPU address space #80525

wants to merge 6 commits into from

Conversation

de-nordic
Copy link
Contributor

The PR consists of:

  • Flash API modification that provides implementation of flash_mmap API call and type definition for flash_driver_api callback.
  • soc_flash_nrf.c driver modification that provides support for the API call
  • Flash Simulator modification that provides support for the API call
  • tests/drivers/flash/common flash_mmap test scenario
  • test/drivers/flash_simulator flash_mmap test scenario

Fixes #80524

@de-nordic de-nordic added this to the v4.1.0 milestone Oct 28, 2024
@de-nordic de-nordic force-pushed the flash-api-mmap branch 4 times, most recently from 3b1db01 to 70dcf36 Compare October 28, 2024 19:25
@de-nordic de-nordic requested a review from rghaddab October 29, 2024 10:42
@de-nordic
drivers/flash: Add new API function flash_mmap
307b998 
The commit adds new API function flash_map with supporting
flash_driver_api callback type.
The new function is provided to allow accessing flash devices,
in particular internal SoC flash devices, via processor address space.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic
drivers/flash/soc_flash_nrf: Add support for flash_map API call
0e32c11 
Adds implementation for mmap callback for flash_driver_api.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic
drivers/flash/flash_simulator: Add support for flash_mmap API call
1569d20 
The commit adds implementation of flash_mmap API call.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic
tests/drivers/flash/common: Add support for testing flash_mmap
a0219be 
Add flash_mmap test scenario.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic
tests/drivers/flash_simulator: Add test scenario for flash_mmap
5fd08b6 
Add testing of flash_mmap implementation of Flash Simulator.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic
tests/flash_api: Test for flash_mmap API call
b652cd3 
Simple tests for flash_mmap API calls.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Monday1908
Monday1908 approved these changes Dec 24, 2024
View reviewed changes
Copy link

@Monday1908 Monday1908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flash charge API

@de-nordic
Copy link
Contributor Author

Flash charge API

Gray area, as does not require any work from other developers to existing code, even though changes flash driver api.

@de-nordic
Copy link
Contributor Author

I am marking this as DNM till I get some input from vendors of SoC devices.

@de-nordic de-nordic added the DNM This PR should not be merged (Do Not Merge) label Dec 25, 2024
@kartben
Copy link
Contributor

kartben commented Jan 18, 2025

@de-nordic is it time to remove DNM?

@de-nordic
Copy link
Contributor Author

@de-nordic is it time to remove DNM?

No. I will bring this into dev/arch meeting first.
This really requires input from other vendors. I have done analysis of flash drivers of soc and spi devices, but I might have missed something and since this is new addition to a stable api, any fixes, specifically that we are nearing release date, may require stable API change.

@de-nordic
Copy link
Contributor Author

@mmahadevan108 @dleach02 Can you take a look in here? We have now issue in MCUboot mcu-tools/mcuboot#1661, that I have reported because people tried to hook flash_area_device_id and are now confused what that thing should return.
Could implementation of the flash_mmap function in Zephyr, as presented by this PR, be providing what is required by you in MCUboot so that we could fix the flash_area_get_device_id to do the thing it should?

@de-nordic de-nordic modified the milestones: v4.1.0, v4.2.0 Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 4, 2025
@de-nordic de-nordic removed the Stale label May 6, 2025
@de-nordic de-nordic mentioned this pull request May 6, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 6, 2025
@de-nordic de-nordic modified the milestones: v4.2.0, v4.3.0 Jul 17, 2025
@de-nordic de-nordic removed the Stale label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anangl anangl Awaiting requested review from anangl

@jaz1-nordic jaz1-nordic Awaiting requested review from jaz1-nordic

@kl-cruz kl-cruz Awaiting requested review from kl-cruz

@magp-nordic magp-nordic Awaiting requested review from magp-nordic

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@nvlsianpu nvlsianpu Awaiting requested review from nvlsianpu

@rghaddab rghaddab Awaiting requested review from rghaddab

1 more reviewer

@Monday1908 Monday1908 Monday1908 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@anangl anangl

@masz-nordic masz-nordic

Labels
area: Flash DNM This PR should not be merged (Do Not Merge) platform: nRF Nordic nRFx
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

Flash API:flash_mmap API call for obtaining flash device mapping in CPU address space
6 participants
@de-nordic @kartben @Monday1908 @anangl @zephyrbot @masz-nordic