Skip to content

modules: nrf_wifi: Allow using a regulator for IOVDD #93676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

modules: nrf_wifi: Allow using a regulator for IOVDD #93676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dts/bindings/wifi/nordic,nrf70.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@
properties:
iovdd-ctrl-gpios:
type: phandle-array
required: true
description: GPIO of the SoC controlling IO_VDD Control pin of the nRF70
description: |
GPIO of the SoC controlling IO_VDD Control pin of the nRF70, either this
or iovdd-regulator needs to be set.

iovdd-regulator:
type: phandle
description: |
Regulator controlling IO_VDD of the nRF70, either this or iovdd-ctrl-gpios
needs to be set.

bucken-gpios:
type: phandle-array
Expand Down
38 changes: 36 additions & 2 deletions modules/nrf_wifi/bus/rpu_hw_if.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,23 @@ LOG_MODULE_REGISTER(wifi_nrf_bus, CONFIG_WIFI_NRF70_BUSLIB_LOG_LEVEL);
static const struct gpio_dt_spec host_irq_spec =
GPIO_DT_SPEC_GET(NRF7002_NODE, host_irq_gpios);

#if DT_NODE_HAS_PROP(NRF7002_NODE, iovdd_ctrl_gpios)

#define NRF70_IOVDD_GPIO 1
static const struct gpio_dt_spec iovdd_ctrl_spec =
GPIO_DT_SPEC_GET(NRF7002_NODE, iovdd_ctrl_gpios);

#elif DT_NODE_HAS_PROP(NRF7002_NODE, iovdd_regulator)

#include <zephyr/drivers/regulator.h>

static const struct device *iovdd_regulator =
DEVICE_DT_GET(DT_PHANDLE(NRF7002_NODE, iovdd_regulator));

#else
#error "nRF70 device either needs iovdd-ctrl-gpios or iovdd-regulator property"
#endif

static const struct gpio_dt_spec bucken_spec =
GPIO_DT_SPEC_GET(NRF7002_NODE, bucken_gpios);

Expand Down Expand Up @@ -173,10 +187,12 @@ static int rpu_gpio_config(void)
{
int ret;

#ifdef NRF70_IOVDD_GPIO
if (!device_is_ready(iovdd_ctrl_spec.port)) {
LOG_ERR("IOVDD GPIO %s is not ready", iovdd_ctrl_spec.port->name);
return -ENODEV;
}
#endif

if (!device_is_ready(bucken_spec.port)) {
LOG_ERR("BUCKEN GPIO %s is not ready", bucken_spec.port->name);
Expand All @@ -189,12 +205,14 @@ static int rpu_gpio_config(void)
return ret;
}

#ifdef NRF70_IOVDD_GPIO
ret = gpio_pin_configure_dt(&iovdd_ctrl_spec, GPIO_OUTPUT);
if (ret) {
LOG_ERR("IOVDD GPIO configuration failed...");
gpio_pin_configure_dt(&bucken_spec, GPIO_DISCONNECTED);
return ret;
}
#endif

LOG_DBG("GPIO configuration done...\n");

Expand All @@ -211,11 +229,13 @@ static int rpu_gpio_remove(void)
return ret;
}

#ifdef NRF70_IOVDD_GPIO
ret = gpio_pin_configure_dt(&iovdd_ctrl_spec, GPIO_DISCONNECTED);
if (ret) {
LOG_ERR("IOVDD GPIO remove failed...");
return ret;
}
#endif

LOG_DBG("GPIO remove done...\n");
return ret;
Expand All @@ -233,15 +253,20 @@ static int rpu_pwron(void)
/* Settling time is 50us (H0) or 100us (L0) */
k_msleep(1);

#ifdef NRF70_IOVDD_GPIO
ret = gpio_pin_set_dt(&iovdd_ctrl_spec, 1);
#else
ret = regulator_enable(iovdd_regulator);
#endif
if (ret) {
LOG_ERR("IOVDD GPIO set failed...");
LOG_ERR("IOVDD enable failed...");
gpio_pin_set_dt(&bucken_spec, 0);
return ret;
}
/* Settling time for IOVDD */
k_msleep(DT_PROP(NRF7002_NODE, iovdd_power_up_delay_ms));

#ifdef NRF70_IOVDD_GPIO
if ((bucken_spec.port == iovdd_ctrl_spec.port) &&
(bucken_spec.pin == iovdd_ctrl_spec.pin)) {
/* When a single GPIO is used, we need a total wait time after bucken assertion
Expand All @@ -252,6 +277,11 @@ static int rpu_pwron(void)

LOG_DBG("Bucken = %d, IOVDD = %d", gpio_pin_get_dt(&bucken_spec),
gpio_pin_get_dt(&iovdd_ctrl_spec));
#else
LOG_DBG("Bucken = %d, IOVDD = %d", gpio_pin_get_dt(&bucken_spec),
regulator_is_enabled(iovdd_regulator) ? 1 : 0);
#endif


return ret;
}
Expand All @@ -260,9 +290,13 @@ static int rpu_pwroff(void)
{
int ret;

#ifdef NRF70_IOVDD_GPIO
ret = gpio_pin_set_dt(&iovdd_ctrl_spec, 0); /* IOVDD CNTRL = 0 */
#else
ret = regulator_disable(iovdd_regulator);
#endif
if (ret) {
LOG_ERR("IOVDD GPIO set failed...");
LOG_ERR("IOVDD disable failed...");
return ret;
}

Expand Down