arm_arch_timer: Move timer enablement after comparison value set #93692
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set The timer is enabled before comparison value is set, which can lead to unexpected behavior if the registers contain uninitialized values. Should call arm_arch_timer_enable() after arm_arch_timer_set_compare(). Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
zephyrbot
added
area: Timer
|
andyross
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer is enabled before comparison value is set, which can lead to unexpected behavior if the registers contain uninitialized values.
Should call arm_arch_timer_enable() after arm_arch_timer_set_compare().
The function calling order in sys_clock_driver_init() is as follows (unsafe):
On the other hand, in smp_timer_init() (safe):