Fix warnings caused by incorrect format specifiers when building for the 64-bit platform #98245
Conversation
zephyrbot
requested review from
JarmouniA,
jfischer-no,
kartben,
nashif and
tmon-nordic
JonyZhang7
force-pushed
the
usb_fix_warning
branch
from
81dc57c to
6781ba8
Compare
JonyZhang7
dismissed stale reviews from JiafeiPan and henrikbrixandersen
via
aa575f3
JonyZhang7
force-pushed
the
usb_fix_warning
branch
from
6781ba8 to
aa575f3
Compare
JonyZhang7
force-pushed
the
usb_fix_warning
branch
from
aa575f3 to
67c8ce8
Compare
JonyZhang7
force-pushed
the
usb_fix_warning
branch
from
464ff85 to
67c8ce8
Compare
subsys/tracing/ctf/tracing_ctf.h
Outdated
| void sys_trace_socket_listen_exit(int sock, int ret); | ||
| void sys_trace_socket_accept_enter(int sock); | ||
| void sys_trace_socket_accept_exit(int sock, const struct sockaddr *addr, const uint32_t *addrlen, | ||
| void sys_trace_socket_accept_exit(int sock, const struct sockaddr *addr, const size_t *addrlen, |
There was a problem hiding this comment.
Looks like stray change, please remove it from this commit.
There was a problem hiding this comment.
Looks like stray change, please remove it from this commit.
thanks, I submit a patch to fix this.
JonyZhang7
force-pushed
the
usb_fix_warning
branch
from
67c8ce8 to
b3c28b4
Compare
JonyZhang7
changed the title
jfischer-no
changed the title
Use zu% format for size_t type. Use d% format for int type. Use u% format for uint32_t type. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com> Signed-off-by: Jony Zhang <jony.zhang@nxp.com>
|
@JonyZhang7 I'm assuming @jfischer-no is referring to the commit titled "tracing: fix build error because of conflicting types". Lets just put text comment in the body of the commit message on what you are doing and not put in the dump of the error. |
thanks |
JonyZhang7
force-pushed
the
usb_fix_warning
branch
2 times, most recently
from
1eb0680 to
5840dfa
Compare
|
Change addrlen parameter type from 'const size_t *' to 'const uint32_t *' to match the declaration in tracing_ctf.h and resolve compilation error. Signed-off-by: Jony Zhang <jony.zhang@nxp.com>
|
@jfischer-no I believe @JonyZhang7 has addressed your requests. Can you confirm. |
|
@JonyZhang7 - can you please link an issue to this PR? A linked issue is required for all bugfix PRs post RC2 |
Hi @cfriedt , this '#97320' leads to this common issue, which is a unmerged PR, we can put this PR into next release, thanks! |
tmon-nordic
left a comment
tmon-nordic
left a comment
There was a problem hiding this comment.
I would prefer to have %zu, %d and u% in the commit message instead of zu%, d% and u%.
8 participants
Use zu% format for size_t type.
Use d% format for int type.
Use u% format for uint32_t type.
fix build error because of conflicting types