-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Update the description of nucleo U385RG-Q arduino_spi dts #98326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @ulrich-a11-y, and thank you very much for your first pull request to the Zephyr project! |
etienne-lms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update your P-R with a single commit (no merge commit) to do the expected change?
I think the expected commit message rather look like the one of your 2nd commit:
boards: st: nucleo_u385rg_q: add spi1 node
Configure and enable SPI1 for Arduino connector
and Update arduino_r3_connector accordlingly.
Signed-off-by: ...
By the way, could you use your real anme in your Singeed-off-by tag (and commit authgership) as expected by the DCO instead of your Github account name.
|
|
||
| &spi1 { | ||
| pinctrl-0 = <&spi1_nss_pa4 &spi1_sck_pa5 | ||
| &spi1_miso_pa6 &spi1_mosi_pa7>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPI1 inctrl conflicts with already enabled nodes in the board DTS.
I think the SPI/Arduino pin mixung is fully legitimate and the conflicting other nodes should be default disabled and enabled only for the tests and samples where we want them.
dac1 node should be default disabled (in this board DTS file) since its pinctrl state conflicts (pin mux dac1_out1_pa4). For this node, we would need an added DTS overlay file in DAC tests:
tests/drivers/dac/dac_loopback/boards/nucleo_u385rg_q.overlay
and tests/drivers/dac/dac_api/boards/nucleo_u385rg_q.overlay
to explicitly enable dac1 node and disable spi1 node.
Ditto for the i2c3 (pin mux i2c3_scl_pa7). Regarding this node, file ./tests/drivers/i2c/i2c_target_api/boards/nucleo_u385rg_q.overlay should explicitly enable i2c3 node and disable spi1 node.
|
|
Thank you, @etienne-lms, for your review. I've closed this PR and opened a new one here: |



The spi1 node is added and arduino_r3_connector.dtsi is updated.
Fixes: #97543