Skip to content

Conversation

@ulrich-a11-y
Copy link
Contributor

@ulrich-a11-y ulrich-a11-y commented Oct 27, 2025

The spi1 node is added and arduino_r3_connector.dtsi is updated.
Fixes: #97543

@github-actions
Copy link

Hello @ulrich-a11-y, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your P-R with a single commit (no merge commit) to do the expected change?
I think the expected commit message rather look like the one of your 2nd commit:

boards: st: nucleo_u385rg_q: add spi1 node

Configure and enable SPI1 for Arduino connector
and Update arduino_r3_connector accordlingly.

Signed-off-by: ...

By the way, could you use your real anme in your Singeed-off-by tag (and commit authgership) as expected by the DCO instead of your Github account name.


&spi1 {
pinctrl-0 = <&spi1_nss_pa4 &spi1_sck_pa5
&spi1_miso_pa6 &spi1_mosi_pa7>;
Copy link
Contributor

@etienne-lms etienne-lms Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPI1 inctrl conflicts with already enabled nodes in the board DTS.
I think the SPI/Arduino pin mixung is fully legitimate and the conflicting other nodes should be default disabled and enabled only for the tests and samples where we want them.

dac1 node should be default disabled (in this board DTS file) since its pinctrl state conflicts (pin mux dac1_out1_pa4). For this node, we would need an added DTS overlay file in DAC tests:
tests/drivers/dac/dac_loopback/boards/nucleo_u385rg_q.overlay
and tests/drivers/dac/dac_api/boards/nucleo_u385rg_q.overlay
to explicitly enable dac1 node and disable spi1 node.

Ditto for the i2c3 (pin mux i2c3_scl_pa7). Regarding this node, file ./tests/drivers/i2c/i2c_target_api/boards/nucleo_u385rg_q.overlay should explicitly enable i2c3 node and disable spi1 node.

@sonarqubecloud
Copy link

@ulrich-a11-y
Copy link
Contributor Author

Thank you, @etienne-lms, for your review. I've closed this PR and opened a new one here:
#98361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nucleo U385RG-Q arduino_spi dts description is wrong

5 participants