-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Adding NiceNano / ali nRF52840 boards suport #99108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @ICantMakeThings, and thank you very much for your first pull request to the Zephyr project! |
|
|
See promicro_nrf52840. |
|
oh mad sorry, i think this is zephyr exclusive as i dont recall it being in platformio, should i close the pr? |
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not accept or support boards in hwmv1 format
|
now I'm not sure, as promicro_nrf52840 already exists, should I close the PR? or change the defines to support a newer hwm version and this will get merged? no point to update it if it won't even get pulled. |
|
If the board you are submitting already exists in tree then yes, close PR, if it is a different board or variant then it can be submitted but this PR would need to be updated to be in hwmv2 format |
|
thaks |



not sure if this will be pulled as it requires being pulled in 2 other repos.
more specifically these 2 pr's:
adafruit/Adafruit_nRF52_Arduino#857
platformio/platform-nordicnrf52#211
the repo is from here