samples: net: qos: Fix technical datarace #99117
Open
+58
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was technically a datarace on the global 'simulated work time' variable. To avoid that transport the information along as part of the net-packet. Signed-off-by: Cla Mattia Galliard <clamattia@gmail.com>
|
jukkar
reviewed
Nov 10, 2025
| net_pkt_cursor_init(pkt); | ||
| net_pkt_set_overwrite(pkt, true); | ||
|
|
||
| /* this sample does not support VLAN */ |
Member
There was a problem hiding this comment.
We could enforce this by adding a Kconfig file for the sample and adding suitable depends on !NET_VLAN entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was technically a datarace on the global 'simulated work time' variable. To avoid that, transport the information along as part of the net-packet.
(Note: it was unlikely an issue, because it was only written, when readers should not have been active, that is why I say
technically)