-
Notifications
You must be signed in to change notification settings - Fork 8.2k
scripts: checkpatch: fix missing blank line detection after declarations #99125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
scripts: checkpatch: fix missing blank line detection after declarations #99125
Conversation
b0e9113 to
3bb9b93
Compare
|
@vignesh-aerlync I tried cherry-picking the offending commit from #98406 that caused me to create the reference issue, and then cherry-picked your commit here, but checkpatch.pl still does not fail. How did you test your changes? |
Thalley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem to fix the issue
I tested it by modifying an existing source file in Zephyr and creating a dummy commit to verify that checkpatch.pl correctly reports the missing blank line warning. |
Thalley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR seems to fix the issue (after doing proper testing). Not sure whether the changes are valid though, so someone who is more familiar with this should review
Thanks for pointing that out . I tested in #98406 ,my patch missed handling that particular case you mentioned. I’ll update my change accordingly. |
Fix checkpatch not warning when blank line after declaration is removed. Updated regexes to also handle context lines, ensuring consistent detection. Fixes: zephyrproject-rtos#98976 Signed-off-by: Vignesh Pandian <vignesh@aerlync.com>
3bb9b93 to
0e6ce57
Compare
|



Fix checkpatch not warning when blank line after declaration
is removed. Updated regexes to also handle context lines,
ensuring consistent detection.
Fixes: #98976