drivers: ethernet: lan9250: add support for a random mac address #99127
+49
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ClaCodes,
decsny,
lmajewski,
maass-hamburg and
pdgendt
dsseng
reviewed
Nov 8, 2025
Member
dsseng
left a comment
dsseng
left a comment
There was a problem hiding this comment.
Thank you! Please find my suggestions below
ckhardin
force-pushed
the
ckhardin/add-random-mac-to-lan9250
branch
from
659344d to
c5e45ea
Compare
Contributor
Author
|
interesting - not sure how the msg wait all stack issues relate to this change - so, need to see if that failure is upstream or in this PR alone? |
Member
Looks like a flaky test, unlikely to be caused by this PR. Someone with the CI access rights will restart the failed twister run and let you know if it is somehow relevant |
maass-hamburg
requested changes
Nov 10, 2025
ckhardin
force-pushed
the
ckhardin/add-random-mac-to-lan9250
branch
from
c5e45ea to
fdaa24c
Compare
maass-hamburg
requested changes
Nov 11, 2025
ckhardin
force-pushed
the
ckhardin/add-random-mac-to-lan9250
branch
from
fdaa24c to
8e34711
Compare
Extend the lan9250 driver to support using a local administered unicast random mac address during init. This follows the device tree settings for zephyr_random_mac_address from other ethernet drivers for the added support. Signed-off-by: Charles Hardin <ckhardin@gmail.com>
The reset gpio field was in the config structure but was not coded into the initialization path. So, add the appropriate code to handle the gpio setup when it is defined in the device tree. Signed-off-by: Charles Hardin <ckhardin@gmail.com>
ckhardin
force-pushed
the
ckhardin/add-random-mac-to-lan9250
branch
from
8e34711 to
1c940f7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the lan9250 driver to support using a local administered unicast random mac address during init. This follows the device tree settings for zephyr_random_mac_address from other ethernet drivers for the added support.