drivers: smbus: fix multiple errors #99128
Open
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
smbus-stm32-add-cast-to-avoid-warning
branch
2 times, most recently
from
de7a7c2 to
ced7dc5
Compare
The smbus driver initialization priority was previously set to `KERNEL_INIT_PRIORITY_DEFAULT` (which is 40). However, the default init priority of devices is typically `KERNEL_INIT_PRIORITY_DEVICE` (which is 50). Since the stm32 smbus driver uses a reference to the underlying i2c device, and since this driver was not being built in CI, this led to the discovery that the smbus driver was initialized too early. ```shell ERROR: Device initialization priority validation failed, the sequence of \ initialization calls does not match the devicetree dependencies. ERROR: /smbus1 <smbus_stm32_init> is initialized before its dependency \ /soc/i2c@40005400 <i2c_stm32_init> (POST_KERNEL+1 < POST_KERNEL+4) ``` By setting the initialization priority to `KERNEL_INIT_PRIORITY_DEVICE`, both smbus1 and i2c1 have their priorities evaluated in the same group, and it becomes possible to determine relative priorities via phandle dependency. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
Previously, the function `smbus_stm32_pcall()` implicitly cast
`uint16_t *` to `uint8_t *`. Add an explicit cast to avoid warning.
```shell
..drivers/smbus/smbus_stm32.c:358:32: error: initialization of \
'uint8_t *' {aka 'unsigned char *'} from incompatible pointer type \
'uint16_t *' {aka 'short unsigned int *'} \
[-Werror=incompatible-pointer-types]
358 | .buf = &send_word,
| ^
..drivers/smbus/smbus_stm32.c:358:32: note: (near initialization \
for 'messages[1].buf')
..drivers/smbus/smbus_stm32.c:363:32: error: initialization of \
'uint8_t *' {aka 'unsigned char *'} from incompatible pointer type \
'uint16_t *' {aka 'short unsigned int *'} \
[-Werror=incompatible-pointer-types]
363 | .buf = recv_word,
| ^~~~~~~~~
```
Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
To ensure that code compiles error (and warning) free, add a build-all testsuite for smbus drivers. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
smbus-stm32-add-cast-to-avoid-warning
branch
from
ced7dc5 to
6960ac6
Compare
cfriedt
changed the title
|
cfriedt
added
bug
zephyrbot
added
the
area: Tests
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
finikorg,
gautierg-st,
juickar,
mathieuchopstm and
nashif
etienne-lms
approved these changes
Nov 10, 2025
mathieuchopstm
approved these changes
Nov 10, 2025
erwango
approved these changes
Nov 10, 2025
Member
Author
|
Adding the 4.3.0 milestone to this, since a regression was added during the stabilization period, since the change itself is quite self-contained, since it fixes multiple bugs, and since it improves stability. |
Member
Author
|
Will determine at the release meeting if this is a "release blocker" and whether it will actually go in to the 4.3.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes multiple errors in in the SMBus area.
CONFIG_KERNEL_INIT_PRIORITY_DEVICEWithout the first fix:
$ twister -i -c -p nucleo_g071rb -T tests/drivers/build_all/smbus/ ... Memory region Used Size Region Size %age Used FLASH: 83416 B 128 KB 63.64% RAM: 11 KB 36 KB 30.56% SRAM0: 0 GB 36 KB 0.00% IDT_LIST: 0 GB 32 KB 0.00% Generating files from ZEPHYR_BASE/twister-out/nucleo_g071rb_stm32g071xx/zephyr/tests/drivers/build_all/smbus/drivers.smbus.build.stm32/zephyr/zephyr.elf for board: nucleo_g071rb ERROR: Device initialization priority validation failed, the sequence of initialization calls does not match the devicetree dependencies. ERROR: /smbus1 <smbus_stm32_init> is initialized before its dependency /soc/i2c@40005400 <i2c_stm32_init> (POST_KERNEL+1 < POST_KERNEL+4) ninja: build stopped: subcommand failed. ...Without the second fix:
Testing done:
Fixes #99129
Fixes #99130
Fixes #99131