drivers/espi: it8xxx2: Add a config to share h2ram pool space #99139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
Chenhongren,
Dino-Li,
RuibinChang,
VenkatKotakonda,
albertofloyd,
fabiobaltieri,
jvasanth1 and
keith-zephyr
Comment on lines
951
to
958
| #ifdef CONFIG_ESPI_IT8XXX2_H2RAM_SHARED | ||
| uint8_t h2ram_pool[MAX(H2RAM_ACPI_SHM_MAX, H2RAM_EC_HOST_CMD_MAX)] | ||
| #else | ||
| static uint8_t h2ram_pool[MAX(H2RAM_ACPI_SHM_MAX, H2RAM_EC_HOST_CMD_MAX)] | ||
| __attribute__((section(".h2ram_pool"))); | ||
| #endif | ||
| __attribute__((section(".h2ram_pool"))); |
Member
There was a problem hiding this comment.
how about using an intermediary macro for the static? something like
#ifdef CONFIG_ESPI_IT8XXX2_H2RAM_SHARED
#define H2RAM_STORAGE
#else
#define H2RAM_STORAGE static
#endif
H2RAM_STORAGE uint8_t h2ram_pool[MAX(H2RAM_ACPI_SHM_MAX, H2RAM_EC_HOST_CMD_MAX)]
__attribute__((section(".h2ram_pool")));just to avoid repeating the allocation since there's some logic in there
The h2ram is an independent 4KB section. With default settings of CONFIG_ESPI_PERIPHERAL_HOST_CMD_PARAM_PORT_NUM and CONFIG_ESPI_PERIPHERAL_ACPI_SHM_REGION_PORT_NUM, There is a 2KB gap that is unused. This change was made to make unused gap can be reused by other modules to reduce overall RAM usage. Signed-off-by: Tim Lin <tim2.lin@ite.corp-partner.google.com>
GTLin08
force-pushed
the
it8xxx2_espi_h2ram_shared
branch
from
cf65fad to
903a81c
Compare
fabiobaltieri
approved these changes
Nov 10, 2025
|
Dino-Li
approved these changes
Nov 10, 2025
Contributor
|
@fabiobaltieri since these changes occur in the SOC file, could you assign this PR to me. |
keith-zephyr
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The h2ram is an independent 4KB section. With default settings of CONFIG_ESPI_PERIPHERAL_HOST_CMD_PARAM_PORT_NUM and CONFIG_ESPI_PERIPHERAL_ACPI_SHM_REGION_PORT_NUM,
There is a 2KB gap that is unused. This change was made to make unused gap can be reused by other modules to reduce overall RAM usage.