Skip to content

Conversation

@ZongchunYu
Copy link
Contributor

No description provided.

Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have LVGL demos in samples/modules/lvgl/demos. You should probably submit this to upstream lvgl demos repo.

Add gui_guider sample

Signed-off-by: Zongchun Yu <zongchun.yu@nxp.com>
@sonarqubecloud
Copy link

@ZongchunYu
Copy link
Contributor Author

We already have LVGL demos in samples/modules/lvgl/demos. You should probably submit this to upstream lvgl demos repo.

Hi JarmouniA,
Thank you for sharing your comments! Since GUI Guider is a UI design IDE based on LVGL, our goal in adding the gui_guider template is to make it easy for UIs designed in GUI Guider to be exported directly to this directory, then compiled and deployed to the board.
Would it make sense to place the gui_guider folder under samples/modules/lvgl/ instead of samples/modules/lvgl/demos/? I am happy to hear your thoughts and any suggestions you might have.

@JarmouniA JarmouniA requested a review from faxe1008 November 13, 2025 07:35
@faxe1008
Copy link
Contributor

@ZongchunYu I get the idea behind this PR, but this is imo the wrong solution. Issues that I see:

  • The sample does not do anything useful out of the box. It does not "show you how to do X".
  • It introduces an intree depedency of a GUI editor into Zephyr. If anything related to the editor breaks, the burden of fixing it and maintaining backwards compatibility is pushed into Zephyr.

What would be more promising I think would be to have a zephyr module on your end and deal with it there.
There is upcoming support for a west templating mechanism which you could use for your sample application:
#99110

In regards to discoverability of your project:
We are happy to add documentation and a link to your Zephyr module: #98219
Also we have this proposal cooking where your model would also find it's place: #98368

@ZongchunYu
Copy link
Contributor Author

@ZongchunYu I get the idea behind this PR, but this is imo the wrong solution. Issues that I see:

  • The sample does not do anything useful out of the box. It does not "show you how to do X".
  • It introduces an intree depedency of a GUI editor into Zephyr. If anything related to the editor breaks, the burden of fixing it and maintaining backwards compatibility is pushed into Zephyr.

What would be more promising I think would be to have a zephyr module on your end and deal with it there. There is upcoming support for a west templating mechanism which you could use for your sample application: #99110

In regards to discoverability of your project: We are happy to add documentation and a link to your Zephyr module: #98219 Also we have this proposal cooking where your model would also find it's place: #98368

Hello faxe1008,

Thanks for your suggestion! I will check how to add this zephyr module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants