-
Notifications
You must be signed in to change notification settings - Fork 757
Add net8.0 target and increase net47 to net472 #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net8.0 target and increase net47 to net472 #1128
Conversation
This is needed for addition Pull Request using Linux Features (TCP KeepAlive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. Just a few comments.
adb056b
to
c953ae8
Compare
I have solved all the problems known to me. |
src/NetMQ/NetMQRuntime.cs
Outdated
@@ -38,7 +36,7 @@ public NetMQRuntime() | |||
/// </summary> | |||
public static NetMQRuntime Current | |||
{ | |||
get { return s_current.Value; } | |||
get { return s_current.Value!; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could return null if no instance of NetMQRuntime
was created. I think we should check for null here and throw an exception that provides some more help than a NRE does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This is in great shape. Almost there. |
Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Drew Noakes <git@drewnoakes.com>
… into feature/net8-target-added
Thank you for the great review. Your comments are very valuable. |
I updated the PR title and description a bit to reflect changes made during the review process, so that they're clearer in the release notes. Thanks very much for driving this forward! |
Published as 4.0.2.0 |
Bumps target frameworks:
net47;netstandard2.1
net8.0;net472;netstandard2.1
The
net8.0
target is needed for #1120, to support TCP keepalive on Linux.We also decided to increase the minimum supported .NET Framework version from 4.7.0 to 4.7.2, to use newer APIs.
Also bumps supporting projects (tests / perf) from
net6.0
tonet9.0
.