Skip to content

Add net8.0 target and increase net47 to net472 #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 13, 2025

Conversation

chrbauer
Copy link
Contributor

@chrbauer chrbauer commented Jun 12, 2025

Bumps target frameworks:

  • Before: net47;netstandard2.1
  • After: net8.0;net472;netstandard2.1

The net8.0 target is needed for #1120, to support TCP keepalive on Linux.

We also decided to increase the minimum supported .NET Framework version from 4.7.0 to 4.7.2, to use newer APIs.

Also bumps supporting projects (tests / perf) from net6.0 to net9.0.

This is needed for addition Pull Request using Linux Features (TCP
KeepAlive)
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Just a few comments.

@chrbauer chrbauer force-pushed the feature/net8-target-added branch from adb056b to c953ae8 Compare June 12, 2025 14:47
@chrbauer
Copy link
Contributor Author

I have solved all the problems known to me.

@@ -38,7 +36,7 @@ public NetMQRuntime()
/// </summary>
public static NetMQRuntime Current
{
get { return s_current.Value; }
get { return s_current.Value!; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could return null if no instance of NetMQRuntime was created. I think we should check for null here and throw an exception that provides some more help than a NRE does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@drewnoakes
Copy link
Member

This is in great shape. Almost there.

Christoph Bauer and others added 5 commits June 13, 2025 08:42
@chrbauer
Copy link
Contributor Author

This is in great shape. Almost there.

Thank you for the great review. Your comments are very valuable.

@drewnoakes drewnoakes changed the title .NET8 as Framework target added Add net8.0 target and increase net47 to net472 Jun 13, 2025
@drewnoakes
Copy link
Member

I updated the PR title and description a bit to reflect changes made during the review process, so that they're clearer in the release notes.

Thanks very much for driving this forward!

@drewnoakes drewnoakes merged commit 2c17a24 into zeromq:master Jun 13, 2025
2 checks passed
@drewnoakes drewnoakes mentioned this pull request Jun 13, 2025
@drewnoakes
Copy link
Member

Published as 4.0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants