Add net8.0 target and increase net47 to net472 #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for addition Pull Request using Linux Features (TCP KeepAlive)
drewnoakes
reviewed
Jun 12, 2025
drewnoakes
reviewed
Jun 12, 2025
drewnoakes
reviewed
Jun 12, 2025
chrbauer
force-pushed
the
feature/net8-target-added
branch
from
adb056b to
c953ae8
Compare
|
I have solved all the problems known to me. |
drewnoakes
reviewed
Jun 13, 2025
drewnoakes
reviewed
Jun 13, 2025
drewnoakes
reviewed
Jun 13, 2025
drewnoakes
reviewed
Jun 13, 2025
src/NetMQ/NetMQRuntime.cs
Outdated
| @@ -38,7 +36,7 @@ public NetMQRuntime() | |||
| /// </summary> | |||
| public static NetMQRuntime Current | |||
| { | |||
| get { return s_current.Value; } | |||
| get { return s_current.Value!; } | |||
There was a problem hiding this comment.
This could return null if no instance of NetMQRuntime was created. I think we should check for null here and throw an exception that provides some more help than a NRE does.
|
This is in great shape. Almost there. |
Co-authored-by: Drew Noakes <git@drewnoakes.com>
Co-authored-by: Drew Noakes <git@drewnoakes.com>
… into feature/net8-target-added
Thank you for the great review. Your comments are very valuable. |
drewnoakes
reviewed
Jun 13, 2025
drewnoakes
changed the title
|
I updated the PR title and description a bit to reflect changes made during the review process, so that they're clearer in the release notes. Thanks very much for driving this forward! |
Closed
|
Published as 4.0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps target frameworks:
net47;netstandard2.1net8.0;net472;netstandard2.1The
net8.0target is needed for #1120, to support TCP keepalive on Linux.We also decided to increase the minimum supported .NET Framework version from 4.7.0 to 4.7.2, to use newer APIs.
Also bumps supporting projects (tests / perf) from
net6.0tonet9.0.