Skip to content

Enable IAsyncEnumerable for netframework #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Enable IAsyncEnumerable for netframework #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/NetMQ.Tests/ClientServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public async Task AsyncWithCancellationToken()
await Assert.ThrowsAnyAsync<OperationCanceledException>(async () => await server.ReceiveStringAsync(source.Token));
}

#if NETSTANDARD || NET
[Fact(Timeout = 120)]
public async Task AsyncEnumerableCanceled()
{
Expand Down Expand Up @@ -155,6 +154,6 @@ public async Task AsyncEnumerable()

Assert.Equal(15002, totalCount);
}
#endif

}
}
2 changes: 2 additions & 0 deletions src/NetMQ/NetMQ.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@
<ItemGroup Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" PrivateAssets="All" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.3" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="9.0.6" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on this

Since this is to enable a single extension method that can be written by the user, maybe it would make sense to forgo adding the Bcl.AsyncInterfaces and let the user create the extension method when needed? Is there any downside adding this dependency that are currently overlooked?

Alternatively, adding this would make it easier to add the IAsyncEnumerable extensions methods on more sockets/use cases.

Personally, I added a few extensions methods with IAsyncEnumerable in my projects but their usecases are probably such that I wouldn't use/depend on those offered by NetMQ.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

My view: The idea of this pull request is to remove a difference between NET and NETFramework. The additional dependency is only added for NETFramework.

Some addition info: https://stackoverflow.com/questions/56651472/does-c-sharp-8-support-the-net-framework

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no clear right answer here. Dependencies shouldn't be added lightly, but the commonality between targets has real value.

If a user on framework upgrades but doesn't ship the new DLL, things will work correctly so long as they don't call these methods, so I think that's ok.

Let's add this. It does seem to simplify things overall.

<Reference Include="System.ServiceModel" />
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />

</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 0 additions & 2 deletions src/NetMQ/RoutingIdSocketExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,6 @@ public static bool TryReceiveString(this IRoutingIdSocket socket, TimeSpan timeo

#region AsyncEnumerable

#if NETSTANDARD || NET

/// <summary>
/// Provides a consuming IAsyncEnumerable for receiving messages from the socket.
Expand All @@ -583,7 +582,6 @@ public static bool TryReceiveString(this IRoutingIdSocket socket, TimeSpan timeo
}
}

#endif

#endregion

Expand Down