Skip to content

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Jun 14, 2024

  1. Streamline by switching eslint-config-atomic -> https://github.com/typescript-eslint.
    Note that this significantly reduces the size of the lockfile.
  2. Add type-aware lint rules.
  3. Allow prettier config to be run separately and use .prettierrc to ignore pnpm lockfile.
  4. Bump prettier. Prettier 3 automatically ignores .gitignore'd files. Also prettier introduces a breaking change on nearly every release so use an exact version number.

Note: I probably should whittle down the existing eslint violations before I take this out of draft phase.

rotu added 5 commits June 14, 2024 14:17
1. Streamline by switching eslint-config-atomic -> @typescript-eslint.
2. Allow prettier config to be run separately and use `.prettierrc` to ignore yaml and md files.
3. Bump prettier. Prettier 3 automatically ignores .gitignore'd files. Also prettier introduces a breaking change on nearly every release so use an exact version number.
make eslint and prettier run in sequence to prevent contention
Comment on lines +2 to +6
"root": true,
"plugins": [
"@typescript-eslint",
"only-warn"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned before, I am not interested in replacing eslint-config-atomic with typescript-eslint as eslint-config-atomic provides the same features and more rules and does not require any configuration.

@aminya aminya closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants