Skip to content

Add support for miniupnpc 2.2.8 #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add support for miniupnpc 2.2.8 #2453

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca9bdf
Add support for support miniupnpc 2.2.8
mwarning Apr 15, 2025
3d757b5
Merge branch 'dev' into upnp
adamierymenko Jul 3, 2025
dc13205
Merge branch 'dev' into upnp
adamierymenko Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion osdep/PortMapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,12 @@ class PortMapperImpl {
OSUtils::ztsnprintf(inport, sizeof(inport), "%d", localPort);

int foundValidIGD = 0;
if ((foundValidIGD = UPNP_GetValidIGD(devlist, &urls, &data, lanaddr, sizeof(lanaddr))) && (lanaddr[0])) {
#if MINIUPNPC_API_VERSION < 18
if ((foundValidIGD = UPNP_GetValidIGD(devlist,&urls,&data,lanaddr,sizeof(lanaddr)))&&(lanaddr[0])) {
#else
if ((foundValidIGD = UPNP_GetValidIGD(devlist,&urls,&data,lanaddr,sizeof(lanaddr),NULL,0))&&(lanaddr[0])) {
#endif

#ifdef ZT_PORTMAPPER_TRACE
PM_TRACE("PortMapper: UPnP: my LAN IP address: %s" ZT_EOL_S, lanaddr);
#endif
Expand Down