fix alignment in readSourceFileToEndAlloc #24518
Open
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Jul 20, 2025
|
hint: make utf16LeToUtf8ArrayList support alignment |
gooncreeper
force-pushed
the
file-read-align
branch
from
146af24 to
282aa8c
Compare
Previously, it would return an align(2) slice as provided by toOwnedSliceSentinel, which was problematic as the callee owns the memory and would mistakingly free it as an align(1) slice. The array list was originally changed to be align(2) to avoid reallocation when converting UTF16LE to UTF8, however this changes it back to align(1) and instead adds a function to std.unicode to convert unaligned codepoints.
gooncreeper
force-pushed
the
file-read-align
branch
from
282aa8c to
8c520aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it would return an align(2) slice as provided by toOwnedSliceSentinel, which was problematic as the callee owns the memory and would mistakingly free it as an align(1) slice.
The array list was originally changed to be align(2) to avoid reallocation when converting UTF16LE to UTF8, however this changes it back to align(1) and instead adds a function to std.unicode to convert unaligned codepoints.