Skip to content

std.fs.File: delete writeFileAll and friends #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 22, 2025
Merged

std.fs.File: delete writeFileAll and friends #24521

merged 10 commits into from
Jul 22, 2025

Conversation

andrewrk
Copy link
Member

@andrewrk andrewrk commented Jul 20, 2025 •
edited
Loading

Disables failing incremental test case, tracked by #24524

Release Notes

  • zig build: print newline before build summary
  • fs.Dir.copyFile no longer can fail with error.OutOfMemory
  • fs.Dir.atomicFile now requires a write_buffer in the options
  • fs.AtomicFile now has a File.Writer field rather than File field
  • fs.File: removed WriteFileOptions, writeFileAll, writeFileAllUnseekable in favor of File.Writer
  • posix.sendfile removed in favor of fs.File.Reader.sendFile

objcopy regressed

Sorry, the code was not up to quality standards and must be reworked. Some functionality remains; others errors with "unimplemented". #24522

@andrewrk andrewrk added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. standard library This issue involves writing Zig code for the standard library. release notes This PR should be mentioned in the release notes. labels Jul 20, 2025
@andrewrk andrewrk force-pushed the fs-streaming branch 2 times, most recently from 98f7ed0 to dbaba3c Compare July 21, 2025 03:46
@andrewrk andrewrk enabled auto-merge July 21, 2025 05:47
andrewrk added 8 commits July 21, 2025 12:32
@andrewrk
std.json: delete dead API
c8c59d7
@andrewrk
build runner: print newline before summary
5df52ca
@andrewrk
std.fs.File: delete writeFileAll and friends
f2a3ac7 
please use File.Writer for these use cases

also breaking API changes to std.fs.AtomicFile
@andrewrk
objcopy: delete most of it
f1576ef 
this code is not up to zig project standards

tracked by #24522

oh, and fix not adjusting buffer seek position in std.fs.File.Reader
@andrewrk
disable failing test
38559e2 
tracked by #24524
@andrewrk
std.fs.File.Reader: only fcopyfile if size available
fe10c66
@andrewrk
std.fs.File.Reader: fix seek position logic
b35c55e
@andrewrk
std.fs.File.Reader: fix sendFile logic
96cbdd1 
it wasn't accounting for both writer and reader buffering
@andrewrk andrewrk disabled auto-merge July 22, 2025 16:39
@andrewrk andrewrk merged commit f34b478 into master Jul 22, 2025
0 of 10 checks passed
@andrewrk andrewrk deleted the fs-streaming branch July 22, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. release notes This PR should be mentioned in the release notes. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewrk