feat(Build.Step.Run): addModifyPathArg #24530
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
std.Build.Step.Run
API assumes path arguments are one of:addFileArg
)addFileOutputArg
)<foo.input
in shell, egaddFileInputArg
)>foo.output
in shell, egcaptureStdOut
)However, some commands modify the data of a path argument instead of generating the result in another location. That is, the path argument is both an input and an output.
As a minimal example, consider
truncate -s 0 foo.txt
. Right now, to create aLazyPath
that represents thefoo.txt
file aftertruncate
has run, some hoops have to be jumped through.This PR adds a method
std.Build.Step.Run.addModifyPathArg
. This new method:LazyPath
argument to the argv of the executed command (similar to egaddFileArg
)LazyPath
argument that resolves to the same path as the inputLazyPath
, but only after the associatedRun
step has completed