Test for ArrayList(u0).toOwnedSlice()
#24531
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #22483, previously, calling
toOwnedSlice()
on anArrayList
of zero-sized type could result in an assertion error depending on the allocator used.The issue has since been fixed in 7eeef5f due to
remap()
's special handling of zero-sized types, but to ensure this doesn't regress I modified the existing test concerningArraylist(u0)
to also includetoOwnedSlice()
.Edit: Forgot to put this here initially (cause I didn't know the syntax), but this should close #22483