Don't tie force_autofix to client capabilities
#2420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `force_autofix` config option would previously be ignored if the client capabilities indicated support for code actions. The intent was to prevent this config option from being enabled in editors that could natively run code action on save. However, there is no reliable way to detect whether a client supports code actions on save so this prevented autofix from being accessible in some editors (Helix).
Techatrix
force-pushed
the
techatrix/force-autofix
branch
from
7d48ccf to
8ae4f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
force_autofixconfig option would previously be ignored if the client capabilities indicated support for code actions. The intent was to prevent this config option from being enabled in editors that could natively run code action on save. However, there is no reliable way to detect whether a client supports code actions on save so this prevented autofix from being accessible in some editors (Helix).