Skip to content

Conversation

@ReFil
Copy link
Contributor

@ReFil ReFil commented Oct 26, 2025

This adds support for the set hid indicators and set physical layout commands to the split transport handler, I've tested the hid indicators and all seems to work as expected

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@ReFil ReFil requested a review from a team as a code owner October 26, 2025 14:21
@caksoylar caksoylar added core Core functionality/behavior of ZMK split labels Oct 27, 2025
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very reasonable. Tested on wireless and wired splits after the change?

@ReFil
Copy link
Contributor Author

ReFil commented Nov 2, 2025

I've been testing it on a dual mode wireless and wired split the past few days with no issues, pre the change when the halves were connected using the wired connector it wouldn't pass hid events to the peripheral and now it does. I haven't tested it on a wireless only split but I can disable wired split on this board and confirm that?

@petejohanson petejohanson merged commit 7738924 into zmkfirmware:main Nov 3, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core functionality/behavior of ZMK split

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants