Skip to content

Conversation

@Kukunin
Copy link

@Kukunin Kukunin commented Jun 21, 2017

It avoid race condition when multiple blockUnlockers instances are running, and they add the reward multiple times.

Before this, two instances might both have taken the same round information, remove it and adds the same reward twice, which ruins the statistic.

It avoid race condition when multiple blockUnlockers are running
@Kukunin
Copy link
Author

Kukunin commented Jun 21, 2017

This code isn't tested, as there is no automatic tests suit and also I don't know the best way to test it.

Please review and give me your opinion on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant