RESOLVED issue where the entrypoint could not support object-based en… #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@bsnuggs1 can you fix the shellcheck errors flagged by CI? |
…vironment variables.
bsnuggs1
force-pushed
the
feature/entrypoint-settings-object-type-support
branch
from
0404e09 to
1071c6b
Compare
Author
|
Sure thing, I applied the fix just now. |
Member
|
Can you show the output of what this generates in a sample case? I'm not convinced that the escaping will actually work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vironment variables.
This change allows majority of the SAML environment variables to be configured via the environment parameter in docker.
I created this change to offer an alternative solution to #242