Skip to content

Add some CI #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 12, 2025
Merged

Add some CI #520

merged 20 commits into from
Nov 12, 2025
+487 −132

Conversation

@alexmv
Copy link
Contributor

@alexmv alexmv commented Oct 30, 2025

Fixes:

How did you test this PR?

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@alexmv alexmv force-pushed the add-some-ci branch 13 times, most recently from 53f8c51 to 8aab833 Compare November 1, 2025 02:16
@alexmv alexmv mentioned this pull request Nov 6, 2025
Open
@alexmv alexmv force-pushed the add-some-ci branch 12 times, most recently from 9496ca5 to 53641cf Compare November 6, 2025 16:06
@alexmv alexmv force-pushed the add-some-ci branch 8 times, most recently from 37beec8 to 284e0b7 Compare November 12, 2025 03:55
@alexmv alexmv marked this pull request as ready for review November 12, 2025 04:00
alexmv added 15 commits November 11, 2025 23:04
@alexmv
github: Spellcheck with typos.
9b897e0
@alexmv
entrypoint: Better error handling on MANUAL_CONFIGURATION errors.
63819f5 
Fixes: #513, #517.
@alexmv
Dockerfile: Pass hadolint.
064dfdf
@alexmv
github: Add hadolint action.
a55ac50
@alexmv
github: Build and push a main image.
f460e46 
Partially addresses #106.
@alexmv
github: Build and push an image for each PR.
c9b6c4b
@alexmv
helm: Pass ct lint.
54bdc5d
@alexmv
helm: Fix containerSecurityContext to run PostgreSQL as non-root.
6e3ed0f 
Fixes: #470.
@alexmv
helm: Switch to bitnamilegacy images.
0fe652a 
These images are not maintained; using them is not a viable long-term
solution.  This causes the Helm chart to at least be installable,
while a long-term fix (most likely by moving off the of Bitnami charts
and images) is worked on.

Fixes #521.

See also #506.
@alexmv
helm: Fix DB_USER to be zulip.
39a714d 
Zulip should connect as the unprivileged zulip user, not postgres.
@alexmv
helm: Fix comments for the right template names.
e2cd5b7
@alexmv
entrypoint: Set a flag to add local gateway IP to LOADBALANCER_IPS.
2d125f5 
This is helpful for Kubernetes, where the health checks will be NAT'd
to come from the local network gateway.
@alexmv
helm: Healthcheck the health-check endpoint.
bbf7f98 
This works around 404s when a realm has not yet been created. We make
use of the new TRUST_GATEWAY_IP, since the healthcheck accesses come
from the local network gateway.

Fixes: #496.
@alexmv
helm: Reorganize values.yaml env vars slightly.
99e8851
@alexmv
github: Lint and test the helm chart.
3041213
@alexmv alexmv merged commit 91e4f6c into main Nov 12, 2025
7 checks passed
@alexmv alexmv deleted the add-some-ci branch November 13, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmv