-
-
Notifications
You must be signed in to change notification settings - Fork 484
Settings: improved visibility of text and buttons #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can you present before/after screenshots? Also, I'm not sure which component is the |
|
Update the description with old and new images... |
|
OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying? |
|
Maybe, but overall this is a definite improvement. |
I think the tab headings should also be in dark colour as it will be a good user experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Please rebase your PR. Requested 1 change, rest looks good.
| .setting-description { | ||
| color: rgb(34 34 34 / 100%); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this anymore, because of b42f9de
What's this PR do?
Improves text and button visibility in settings page as reported in #1357
Screenshots?

Old:
New:

You have tested this PR on: