katex: Remove renderKaTex experimental flag

[rajveermalviya]

This flag has been enabled since v0.0.29 (beta) release, and we don't plan to disable it. So remove the flag completely, simplifying related code.

Fixes: #1728

[gnprice]

Thanks for cleaning this up! Generally all looks good; small comments below.

[gnprice]

nit:

content test [nfc]: Drop duplicate skipped KaTeX font-size ratio test

rather, it's a skipped duplicate such test — there's another KaTeX font-size ratio test, which this is a duplicate of, but there's no other skipped KaTeX font-size ratio test, so it can't be a duplicate within that category.

[gnprice]

Also please add a sentence to the commit message clarifying that the existing test this duplicates is the one above it, not the one below. I initially read it as the latter (because the descriptions match — my conflict-resolution error, probably, somewhere in the chain of cherry-picking that led to b073c6b / #1270), and was going to comment that it's not actually a duplicate of that 🙂

[gnprice]

nit: make summary line more specific

content test [nfc]: Reorder KaTeX widget tests

With renderKatex flag enabled (and soon to be default behaviour)
being first.

There's room in that summary line to put some of that information from the body, to give an idea of what the reordering is about. Like:

content test [nfc]: Reorder KaTeX widget tests, enabled before disabled

[gnprice]

Since this HTML isn't something the server actually generates, this markdown field should be null. See its doc:

  /// The Zulip Markdown source, if any, that the server renders as [html].
  ///
  /// This is useful for reproducing the example content for live use in the
  /// app, and as a starting point for variations on it.
  ///
  /// Currently the test suite does not verify the relationship between
  /// [markdown] and [html].
  ///
  /// If there is no known Markdown that a Zulip server can render as [html],
  /// then this should be null and a comment should explain why the test uses
  /// such an example.
  final String? markdown;

So e.g., following the example emojiUnicodeClassesFlipped:

Suggested change

	static final mathInlineUnknown = ContentExample.inline(
	'inline math',
	r"$$ \lambda $$",
	static final mathInlineUnknown = ContentExample.inline(
	'inline math',
	null, // r"$$ \lambda $$" (hypothetical server variation)

[gnprice]

nit: "fallback" is a noun, "fall back" the verb:

Suggested change

	testWidgets('maintains font-size ratio with surrounding text, when fallback to TeX source', (tester) async {
	testWidgets('maintains font-size ratio with surrounding text, when falling back to TeX source', (tester) async {

[rajveermalviya]

Thanks for the review @gnprice! Pushed an update, PTAL.

[gnprice]

I think you made this edit on a different example than intended 🙂

[rajveermalviya]

Ahh, should be fixed now.

[rajveermalviya]

Thanks for the review @gnprice! Pushed an update, PTAL.

[gnprice]

Thanks! Merging, with a tweak in one commit message (cf #1742 (comment)):

$ git range-diff origin pr/1742 @
1:  edfb68198 ! 1:  8c9a7b0ce content test [nfc]: Drop skipped duplicate KaTeX font-size ratio test
    @@ Commit message
         This skipped test is a duplicate of the one above it, but
         incorrectly has the description of the one below it. Probably a
         result of conflict-resolution error in b073c6b26 which introduced
    -    this duplicate.
    +    this duplicate, or another in the chain of cherry-picks that led to
    +    that commit.
     
      ## test/widgets/content_test.dart ##
     @@ test/widgets/content_test.dart: void main() {
2:  95c25c6c3 = 2:  6459af689 content test [nfc]: Reorder KaTeX widget tests, enabled before disabled
3:  ccf262f4c = 3:  da5c1f706 katex: Remove renderKaTex experimental flag