Skip to content

fix for unread button on unsubscribed channels #1641 #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix for unread button on unsubscribed channels #1641 #1758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91246ee
fix for : Don't show "Mark as unread from here" button in unsubscrib…
loveucifer Jul 28, 2025
f4fdacd
actions: Omit 'Mark as unread' for messages in unsubscribed streams.
loveucifer Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/widgets/action_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,8 @@ void showMessageActionSheet({required BuildContext context, required Message mes

final isMessageRead = message.flags.contains(MessageFlag.read);
final markAsUnreadSupported = store.zulipFeatureLevel >= 155; // TODO(server-6)
final showMarkAsUnreadButton = markAsUnreadSupported && isMessageRead;
final showMarkAsUnreadButton = markAsUnreadSupported && isMessageRead &&
(message is! StreamMessage || store.subscriptions[message.streamId] != null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final showMarkAsUnreadButton = markAsUnreadSupported && isMessageRead &&
(message is! StreamMessage || store.subscriptions[message.streamId] != null);
final showMarkAsUnreadButton = markAsUnreadSupported && isMessageRead &&
(message is! StreamMessage || store.subscriptions[message.streamId] != null);


final isSenderMuted = store.isUserMuted(message.senderId);

Expand Down