msglist test: Wait through a nav-transition animation in a place we forgot #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
|
Thanks for taking care of this! Looks good, except it doesn't work with the Flutter version that's currently in pubspec.yaml. So this should come atop a Flutter upgrade (like #1755). |
|
OK, #1763 for a Flutter upgrade that would enable this. |
chrisbobbe
force-pushed
the
pr-pump-through-transition
branch
from
aa51a5e to
9ba4968
Compare
|
Thanks! Revision pushed; this one includes that not-yet-merged upgrade. |
|
Infra failure in CI: Rerunning. |
…orgot This should unblock the upstream PR flutter/flutter#165832 . Discussion: flutter/flutter#165832 (comment) (And, for consistency, also use upstream's new TransitionDurationObserver in a place we were getting a duration more manually. This weakens the test a bit, by removing checks that the duration comes from a popped route, with specific details of the route that was popped. Perhaps we can add a feature to TransitionDurationObserver to get those checks back, but not a priority for now.)
gnprice
force-pushed
the
pr-pump-through-transition
branch
from
9ba4968 to
c87de41
Compare
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Jul 30, 2025
Follow up to #464. Unblocks PR flutter/flutter#165832 by picking up a fix for a failure on that PR (zulip/zulip-flutter#1761).
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2025
For #165832, picks up the test change from zulip/zulip-flutter#1761 that was bumped in the tests repo in flutter/tests#466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.