-
Notifications
You must be signed in to change notification settings - Fork 154
[ACS-10165] create all libraries component #4826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-10165] create all libraries component #4826
Conversation
|
@g-jaskowski I found issue probably. In ADW we could open sidebar for some libraries even when we are not member of them but now in ACA it's disabled. In ADW it was possible, the only thing is that we could not edit fields. |
projects/aca-content/src/lib/components/library-list/library-list.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.html
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/library-list/library-list.component.spec.ts
Outdated
Show resolved
Hide resolved
|
@g-jaskowski I believe we should to also move e2es related with moved code to ACA. If we won't move it now then ACA part of All Libraries won't be safe so somebody can merge some change which breaks it so better to move them as part of that PR to have it secured immediately |
|
@g-jaskowski I found important bug.
You need to verify all actions on Records Management lib itself and everything what is inside like holds, files in holds etc. because we added multiple validation there which check roles. It was done as that MNT: https://hyland.atlassian.net/browse/MNT-24923 so we need that as it was MNT. Only problem which I see is that there may be a problem to check it properly because all validations are in ADW and I think ACA should not to know anything about holds, records etc. Screen.Recording.2025-10-03.at.09.12.05.mov |
@g-jaskowski Regarding to that comment about e2e - please check with Adam or Akash if you should to remove e2es in ADW which you move to ACA (and just leave e2es in ADW for extended part) OR if those e2es should be in both ACA and ADW |
1af180b to
68c9080
Compare
Issue fixed, details are accessible in info drawer
All e2es using All Libraries page in ADW are related to ADW exclusive member management feature. There were no tests that could be moved, I've let Adam know that those are missing.
I've adjusted the api call arguments so that only base template sites are fetched. Other available templated are related to Record Management. |
|
@g-jaskowski there is also component called libraries.component.ts - please check if we can reuse instead of adding new one |
ccdf84f to
fb4c3d4
Compare
@g-jaskowski there left this one comment, please have a look |
c52042c to
4f6b2e6
Compare
projects/aca-content/src/lib/components/favorite-libraries/favorite-libraries.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/libraries-base/libraries-base.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/libraries-base/libraries-base.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/libraries/libraries.component.ts
Outdated
Show resolved
Hide resolved
|







https://hyland.atlassian.net/browse/ACS-10165