Skip to content

Conversation

@g-jaskowski
Copy link
Contributor

@AleksanderSklorz
Copy link
Contributor

@g-jaskowski I found issue probably. In ADW we could open sidebar for some libraries even when we are not member of them but now in ACA it's disabled. In ADW it was possible, the only thing is that we could not edit fields.

ADW:
image

ACA:
image

@AleksanderSklorz
Copy link
Contributor

@g-jaskowski I believe we should to also move e2es related with moved code to ACA. If we won't move it now then ACA part of All Libraries won't be safe so somebody can merge some change which breaks it so better to move them as part of that PR to have it secured immediately

@AleksanderSklorz
Copy link
Contributor

@g-jaskowski I found important bug.

  1. Create Records Management lib in Share.
  2. Configure hruser to have access to that lib (example of configuration can be found in video).
  3. If you open that lib in ACA then you can see more available actions like for example Remove file from hold (but user has not capability for that added in user's role).
  4. Try the same in ADW - those options are hidden when user has not capability. They should be visible only when user has capabilities for that.

You need to verify all actions on Records Management lib itself and everything what is inside like holds, files in holds etc. because we added multiple validation there which check roles. It was done as that MNT: https://hyland.atlassian.net/browse/MNT-24923 so we need that as it was MNT.

Only problem which I see is that there may be a problem to check it properly because all validations are in ADW and I think ACA should not to know anything about holds, records etc.

Screen.Recording.2025-10-03.at.09.12.05.mov

@AleksanderSklorz
Copy link
Contributor

@g-jaskowski I believe we should to also move e2es related with moved code to ACA. If we won't move it now then ACA part of All Libraries won't be safe so somebody can merge some change which breaks it so better to move them as part of that PR to have it secured immediately

@g-jaskowski Regarding to that comment about e2e - please check with Adam or Akash if you should to remove e2es in ADW which you move to ACA (and just leave e2es in ADW for extended part) OR if those e2es should be in both ACA and ADW

@g-jaskowski g-jaskowski force-pushed the ACS-10165-Move-All-Libraries-page-to-ACA branch from 1af180b to 68c9080 Compare October 10, 2025 15:32
@g-jaskowski
Copy link
Contributor Author

g-jaskowski commented Oct 10, 2025

@g-jaskowski I found issue probably. In ADW we could open sidebar for some libraries even when we are not member of them but now in ACA it's disabled. In ADW it was possible, the only thing is that we could not edit fields.

ADW: image

ACA: image

Issue fixed, details are accessible in info drawer

@g-jaskowski I believe we should to also move e2es related with moved code to ACA. If we won't move it now then ACA part of All Libraries won't be safe so somebody can merge some change which breaks it so better to move them as part of that PR to have it secured immediately

All e2es using All Libraries page in ADW are related to ADW exclusive member management feature. There were no tests that could be moved, I've let Adam know that those are missing.

@g-jaskowski I found important bug.

  1. Create Records Management lib in Share.
  2. Configure hruser to have access to that lib (example of configuration can be found in video).
  3. If you open that lib in ACA then you can see more available actions like for example Remove file from hold (but user has not capability for that added in user's role).
  4. Try the same in ADW - those options are hidden when user has not capability. They should be visible only when user has capabilities for that.

You need to verify all actions on Records Management lib itself and everything what is inside like holds, files in holds etc. because we added multiple validation there which check roles. It was done as that MNT: https://hyland.atlassian.net/browse/MNT-24923 so we need that as it was MNT.

Only problem which I see is that there may be a problem to check it properly because all validations are in ADW and I think ACA should not to know anything about holds, records etc.

Screen.Recording.2025-10-03.at.09.12.05.mov

I've adjusted the api call arguments so that only base template sites are fetched. Other available templated are related to Record Management.

@AleksanderSklorz
Copy link
Contributor

@g-jaskowski there is also component called libraries.component.ts - please check if we can reuse instead of adding new one

@g-jaskowski g-jaskowski force-pushed the ACS-10165-Move-All-Libraries-page-to-ACA branch 2 times, most recently from ccdf84f to fb4c3d4 Compare October 15, 2025 14:42
@AleksanderSklorz
Copy link
Contributor

@g-jaskowski there is also component called libraries.component.ts - please check if we can reuse instead of adding new one

@g-jaskowski there left this one comment, please have a look

@g-jaskowski g-jaskowski force-pushed the ACS-10165-Move-All-Libraries-page-to-ACA branch from c52042c to 4f6b2e6 Compare October 22, 2025 08:30
@sonarqubecloud
Copy link

@g-jaskowski g-jaskowski merged commit 3386af5 into develop Oct 24, 2025
28 checks passed
@g-jaskowski g-jaskowski deleted the ACS-10165-Move-All-Libraries-page-to-ACA branch October 24, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants