Use autolayout for loading indicator

[antrix1989]

Proposed changes

Use autolayout for loading indicator

Type of change

• Feature work
• Bug fix
• Documentation
• Engineering change
• Test
• Logging/Telemetry

Risk

• High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
• Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
• Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

[Copilot]

Pull request overview

This PR introduces autolayout support for the loading indicator in the macOS webview UI controller, controlled by a feature flag. The changes aim to modernize the layout approach from frame-based positioning to constraint-based autolayout.

• Adds a new feature flag MSID_FLIGHT_USE_AUTOLAYOUT_FOR_LOADING_INDICATOR to enable/disable autolayout behavior
• Replaces magic number 32 with named constant MSID_LOADING_INDICATOR_SIZE for better maintainability
• Implements autolayout constraints to center the loading indicator in the webview

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
IdentityCore/src/MSIDConstants.h	Declares the new feature flag constant for autolayout control
IdentityCore/src/MSIDConstants.m	Defines the feature flag constant with its string value
IdentityCore/src/webview/embeddedWebview/ui/mac/MSIDWebviewUIController.m	Adds autolayout implementation for the loading indicator, defines size constant, and replaces magic numbers

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[kaisong1990]

minor question