-
Notifications
You must be signed in to change notification settings - Fork 23
Add PerfTrace API and add tracing to XmlHttpRequest #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add some more tracing in XmlHttpRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a platform-agnostic PerfTrace API that wraps arcana's trace_region functionality and integrates performance tracing into XMLHttpRequest operations. The implementation depends on updates to the upstream arcana.cpp library.
- Introduces a new
PerfTraceAPI with configurable trace levels and handle management - Adds performance tracing to XMLHttpRequest's
SendandRaiseEventmethods - Updates CMake configuration to link Foundation library with required dependencies
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Core/Foundation/Include/Babylon/PerfTrace.h | Declares the public PerfTrace API with Level enum and Handle class |
| Core/Foundation/Source/PerfTrace.cpp | Implements PerfTrace API with arcana trace_region wrapping and Napi interop |
| Core/Foundation/CMakeLists.txt | Adds PerfTrace files and links Foundation with napi and arcana dependencies |
| Polyfills/XMLHttpRequest/Source/XMLHttpRequest.h | Adds m_url member to store URL for tracing purposes |
| Polyfills/XMLHttpRequest/Source/XMLHttpRequest.cpp | Integrates tracing into Send and RaiseEvent operations |
| CMakeLists.txt | Updates arcana.cpp dependency to personal fork with tracing support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…JsRuntime's Foundation lib (#1569) This PR depends on BabylonJS/JsRuntimeHost#125 - Rework NativeTracing to be build on top of the new PerfTrace helper from JsRuntime's Foundation lib. - Add NativeTracing to the iOS app (the platform tracing is currently implemented for). - Add a commented out line in experience.js that enables tracing through the Babylon.js API.
This PR depends on microsoft/arcana.cpp#51