[BAH-4159] Loading All Privileges when assign #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| collectAllPrivileges(initialPrivileges, allPrivileges) { | ||
| allPrivileges.push(...initialPrivileges.results); | ||
| if (initialPrivileges.links.length > 0 && initialPrivileges.links.find(link => link.rel === "next") !== undefined) { | ||
| httpInterceptor.get(initialPrivileges.links[0].uri) |
There was a problem hiding this comment.
What happens if the API has a bug? If the API incorrectly keeps returning a "next" link indefinitely, this function never stops calling itself. Could introducing a limit be a safer option?
There was a problem hiding this comment.
We can introduce a limit but its like we are not trusting our systems.
There was a problem hiding this comment.
It's always a good practice to introduce a limit. It's not that we are not trusting our systems but it's defensive programming to avoid rare but critical issues. Logic wise, it's all good.
There was a problem hiding this comment.
Sure, I'll go ahead and add a limit
There was a problem hiding this comment.
@arshiyaTW2021 I have added the limit.
…ted. Updating name for the limit constant
arshiyaTW2021
approved these changes
Mar 19, 2025
arshiyaTW2021
approved these changes
Mar 21, 2025
mohan-13
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BAH-4159
This PR fixes the bug - Not all privileges are loaded when assigning to forms as the API is paginated.
Fetching all the privileges and then assigning it to the dropdown
BAH-4186
This PR also fixes the bug - Not all forms are loaded in thr form builder list page as the API is paginated