Skip to content

[BAH-4159] Loading All Privileges when assign #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2025
Merged

[BAH-4159] Loading All Privileges when assign #118

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8c06db
Fetching all privileges from the paginated API
kushboojain-iplit Jan 16, 2025
9610d6b
Searching for next link if present
kushboojain-iplit Jan 16, 2025
1444958
Adding a limit to fetch the priviledges
kushboojain-iplit Mar 7, 2025
6d67f99
Fetching complete response for all forms as the openmrs API is pagina…
kushboojain-iplit Mar 13, 2025
bf7a506
Fixing lint errors
kushboojain-iplit Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/form-builder/components/FormPrivilegeTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,30 @@ export default class FormPrivilegeTable extends Component {
this.setState({ loading: false });
});
}

fetchPrivileges() {
let initialPrivileges = [];
let privileges = [];
const queryParams = '?=';
const optionsUrl = `${formBuilderConstants.formPrivilegeUrl}${queryParams}`;
httpInterceptor.get(optionsUrl)
.then((initialPrivileges) => {
this.setState({ availablePrivileges: this.arrangePrivileges(initialPrivileges.results), loading: false });
this.collectAllPrivileges(initialPrivileges, privileges);
});
}

collectAllPrivileges(initialPrivileges, allPrivileges) {
allPrivileges.push(...initialPrivileges.results);
if (initialPrivileges.links.length > 0 && initialPrivileges.links.find(link => link.rel === "next") !== undefined) {
httpInterceptor.get(initialPrivileges.links[0].uri)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the API has a bug? If the API incorrectly keeps returning a "next" link indefinitely, this function never stops calling itself. Could introducing a limit be a safer option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can introduce a limit but its like we are not trusting our systems.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a good practice to introduce a limit. It's not that we are not trusting our systems but it's defensive programming to avoid rare but critical issues. Logic wise, it's all good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll go ahead and add a limit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshiyaTW2021 I have added the limit.

.then((privileges) => {
return this.collectAllPrivileges(privileges, allPrivileges)
});
} else {
this.setState({ availablePrivileges: this.arrangePrivileges(allPrivileges), loading: false });
}
}

fetchFormPrivilegesFromDB() {
let initialPrivilegesFromDB = [];
const queryParams = '?=';
Expand Down