Skip to content

Fix json schema example #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahouseholder merged 6 commits into from
Feb 18, 2025
Merged

Fix json schema example #684

ahouseholder merged 6 commits into from
Feb 18, 2025

Conversation

@sei-renae
Copy link
Contributor

@sei-renae sei-renae commented Feb 17, 2025 •
edited by ahouseholder
Loading

@ahouseholder ahouseholder self-assigned this Feb 17, 2025
@ahouseholder ahouseholder changed the title Resolve issue 584 Fix json schema example Feb 17, 2025
ahouseholder
ahouseholder reviewed Feb 17, 2025
View reviewed changes
data/schema_examples/Computed-CVE-2014-0751-Coordinator-with-tree.json
Copy link
Contributor

@ahouseholder ahouseholder Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right. Why would Exploitation have a key of "V"? "V" used to be Virulence, which was replaced by "Automatable" ("A"). So this change to "Exploitation" seems out of place.

Copy link
Contributor Author

@sei-renae sei-renae Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that I went to L34 instead of L54. Update incoming.

Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thes scheme example should go in an archive folder, we no longer support this format
data/schema_examples/Computed-CVE-2014-0751-Coordinator-with-tree.json

Copy link
Contributor

@ahouseholder ahouseholder Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spawned @sei-vsarvepalli 's comment into a new issue #687 so we don't have to hold this PR for merging

ahouseholder
ahouseholder requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@ahouseholder ahouseholder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one note about exploitation, virulence, and automatable to be fixed.

Also, we should plan to merge this one after #683 because both PRs touch some of the same files, and it will be easier to resolve conflicts if we merge #683 before #684 (this PR).

@ahouseholder ahouseholder added this to the 1Q25 milestone Feb 17, 2025
@ahouseholder ahouseholder mentioned this pull request Feb 18, 2025
Closed
ahouseholder
ahouseholder approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge shortly.

data/schema_examples/Computed-CVE-2014-0751-Coordinator-with-tree.json
Copy link
Contributor

@ahouseholder ahouseholder Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spawned @sei-vsarvepalli 's comment into a new issue #687 so we don't have to hold this PR for merging

@ahouseholder ahouseholder merged commit 3008938 into CERTCC:main Feb 18, 2025
1 check passed
@sei-renae sei-renae deleted the 584 branch February 19, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahouseholder ahouseholder ahouseholder approved these changes

@sei-vsarvepalli sei-vsarvepalli Awaiting requested review from sei-vsarvepalli sei-vsarvepalli is a code owner

Assignees

@ahouseholder ahouseholder

Labels

None yet

Projects

None yet

Milestone

2025-03

Development

Successfully merging this pull request may close these issues.

There might be a typo in the ssvc data example.

3 participants

@sei-renae @ahouseholder @sei-vsarvepalli