Skip to content

Fix json schema example #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahouseholder merged 6 commits into from
Feb 18, 2025
Merged

Fix json schema example #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cf6faa
Standardize docstrings to define what the program does, add missing l…
sei-renae Feb 5, 2025
357c35c
Fix most merge conflicts
sei-renae Feb 5, 2025
745b879
Update schemas for typos
sei-renae Feb 17, 2025
300da84
Update mission_prevalence.py
ahouseholder Feb 17, 2025
1baf9c6
Merge branch 'main' into 584
ahouseholder Feb 17, 2025
33889f0
Update 'virulence' to 'automatable'
sei-renae Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/schema_examples/Computed-CVE-2014-0751-Coordinator-with-tree.json
View file
Open in desktop
Copy link
Contributor

@ahouseholder ahouseholder Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right. Why would Exploitation have a key of "V"? "V" used to be Virulence, which was replaced by "Automatable" ("A"). So this change to "Exploitation" seems out of place.

Copy link
Contributor Author

@sei-renae sei-renae Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that I went to L34 instead of L54. Update incoming.

Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thes scheme example should go in an archive folder, we no longer support this format
data/schema_examples/Computed-CVE-2014-0751-Coordinator-with-tree.json

Copy link
Contributor

@ahouseholder ahouseholder Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spawned @sei-vsarvepalli 's comment into a new issue #687 so we don't have to hold this PR for merging

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"role": "Coordinator",
"id": "CVE-2014-0751",
"version": "2.0.3",
"computed": "SSVCv2/E:A/V:S/T:T/P:M/B:A/M:M/D:A/2021-09-29T15:29:44Z/",
"computed": "SSVCv2/E:A/A:N/T:T/P:M/B:A/M:M/D:A/2021-09-29T15:29:44Z/",
"timestamp": "2021-09-29T15:29:44Z",
"options": [
{
Expand Down Expand Up @@ -52,7 +52,7 @@
},
{
"label": "Automatable",
"key": "V",
"key": "A",
"decision_type": "simple",
"options": [
{
Expand Down
2 changes: 1 addition & 1 deletion data/schema_examples/Computed-CVE-2014-0751-Coordinator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"role": "Coordinator",
"id": "CVE-2014-0751",
"version": "2.0.3",
"computed": "SSVCv2/E:A/V:S/T:T/P:M/B:A/M:M/D:A/2021-09-29T15:29:44Z/",
"computed": "SSVCv2/E:A/A:N/T:T/P:M/B:A/M:M/D:A/2021-09-29T15:29:44Z/",
"timestamp": "2021-09-29T15:29:44Z",
"options": [
{
Expand Down
2 changes: 1 addition & 1 deletion src/ssvc/decision_points/mission_prevalence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env python

"""
Provides the Mission Prevalence decision point and its values."
Provides the Mission Prevalence decision point and its values.
"""

# Copyright (c) 2024-2025 Carnegie Mellon University and Contributors.
Expand Down
1 change: 0 additions & 1 deletion src/ssvc/decision_points/utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"""

# Copyright (c) 2024-2025 Carnegie Mellon University and Contributors.
# - see Contributors.md for a full list of Contributors
# - see ContributionInstructions.md for information on how you can Contribute to this project
# Stakeholder Specific Vulnerability Categorization (SSVC) is
# licensed under a MIT (SEI)-style license, please see LICENSE.md distributed
Expand Down