Skip to content

Conversation

jlahovnik
Copy link
Collaborator

If only one asset is download, we attempt to create a pre-signed url. If this is successful, a RedirectResponse is returned instead of calling the _stream_download_dict method.

@jlahovnik jlahovnik self-assigned this Jul 28, 2025
Copy link

github-actions bot commented Jul 28, 2025

Test Results

 1 files   -   3   1 suites   - 3   7s ⏱️ -28s
88 tests +  1  86 ✅  -   1  0 💤 ±0  1 ❌ +1  1 🔥 +1 
88 runs   - 260  86 ✅  - 262  0 💤 ±0  1 ❌ +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 95fef99. ± Comparison against base commit 398addb.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
tests.test_telemetry ‑ test_create_meter_provider
tests.test_telemetry ‑ test_create_tracer_provider
tests.test_download ‑ test_download_redirect_response
tests.test_telemetry ‑ test_get_meter_provider
tests.test_telemetry ‑ test_get_tracer_provider

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 28, 2025

badge

Code Coverage

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/api.py                                 8       8  0.00%    20-37
eodag/app.py                                75      15  80.00%   149, 163-170, 181-183, 232-244, 248
eodag/client.py                             25       0  100.00%
eodag/config.py                             18       0  100.00%
eodag/constants.py                           6       0  100.00%
eodag/core.py                              276      53  80.80%   131-132, 142, 272-273, 353, 473-478, 488-489, 510, 525-543, 606-607, 631, 647-651, 665-669, 671-675, 680, 692-724
eodag/cql_evaluate.py                       48      27  43.75%   43, 48, 53, 58, 74-99, 104-106, 111
eodag/dag.py                                53       0  100.00%
eodag/errors.py                             94      12  87.23%   143, 160-163, 179, 202-212
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      13  68.29%   44, 68-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42      12  71.43%   45-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        65       3  95.38%   83-84, 95
eodag/extensions/data_download.py          122      47  61.48%   61-73, 94, 112-113, 120, 135-142, 147-148, 155-183, 186-195
eodag/extensions/ecmwf.py                   69       0  100.00%
eodag/extensions/filter.py                  55       2  96.36%   196-197
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/extensions/pagination.py              15       0  100.00%
eodag/extensions/stac.py                   132       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/links.py                      133      13  90.23%   36, 90-92, 185, 203, 235, 282, 331-342
eodag/models/stac_metadata.py              186       8  95.70%   98, 181, 183, 196-203, 261
TOTAL                                     1638     249  84.80%

Diff against main

Filename                             Stmts    Miss  Cover
---------------------------------  -------  ------  -------
eodag/extensions/data_download.py      +11      +9  -4.29%
TOTAL                                  +11      +9  -0.45%

Results for commit: 95fef99

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@jlahovnik
Copy link
Collaborator Author

build is currently failing because method presign_url only exists on feature branch of eodag

@jlahovnik jlahovnik force-pushed the redirect-presigned-urls branch from 17360c8 to cc3b400 Compare September 19, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant