AboutActivity to Jetpack Compose

[TheLastProject]

• Composify
• Hide elements when they should be hidden
• Don't crash when clicking an element
• Fix tests
• Fix Compose not applying pure black OLED switch
• Remove colour selection options in Catima (to simplify migration) - See Remove theme colour support #2897
• Ensure consistency with other activity designs

[theimpulson]

I would extract the logic for the actual screen content in a separate function. That would make it easier to preview the UI and test it with fake data. Example, Documentation

[theimpulson]

Missing new line? Maybe also a Preview?

[TheLastProject]

Main blocker here is that I haven't found the time to deal with fixing the tests yet (quite a different way of testing) and I'm hesitant to just remove the tests (though maybe I should to at least progress somewhat).

I think the general code is probably pretty OK by now, just needs the custom colour support removed for consistency between XML and Compose.

[vijay2909]

Thanks for the update! I took a look and went ahead with some optimizations in AboutActivity. I’ve also fixed a few of the existing tests and added some new ones to improve coverage. Hopefully, this helps unblock some of the progress you mentioned. Let me know if you’d like me to push these changes for review or if you’d prefer I open a separate PR.

[TheLastProject]

I should probably watch out to not try to be too perfectionist about this. It's pretty good and honestly it looks consistent enough, aside from the "Pure black background for dark theme" option not being applied. So need to figure out how to fix that (I would like Catima to be compatible with those weird eink phones, which this setting would also help with).

So, plan:

1. Figure out why the pure black thing doesn't work and fix it - DONE :)
2. Squash merge this MR (because the commit history is kinda messy, but also makes some sense, so I would like the MR to at least stay like this and not squash it before merging)
3. Put removing the colour setting in a separate MR to merge straight after (to keep this MR's commit history clean but have removing the colour settings in a separate MR)

I think it's good enough to consider "done", even though we don't have a test for opening the browser yet, because otherwise it'll never get done 😅

[TheLastProject]

I'll sleep on this a bit, but most likely both this and #2897 are ready to merge (please speak up if you disagree!). Exciting to finally have a bit of Compose in Catima! Really feels nice to shed some legacy code slowly :)