Remove theme colour support #2897
Merged
+1
−927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
recursiveribbons
approved these changes
Dec 26, 2025
Contributor
recursiveribbons
left a comment
recursiveribbons
left a comment
There was a problem hiding this comment.
It's nice to remove the mega if statement. Good cleanup
This simplifies the codebase and new Compose implementation. If this feature is really wanted by the community, it could possibly be reimplemented in a much more flexible way (choosing the exact colour) after all UIs are migrated to Compose, as Compose can generate a theme based on just a primary colour.
TheLastProject
force-pushed
the
remove/colorOptions
branch
from
b016051 to
c202c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the codebase and new Compose implementation. If this feature is really wanted by the community, it could possibly be reimplemented in a much more flexible way (choosing the exact colour) after all UIs are migrated to Compose, as Compose can generate a theme based on just a primary colour.
Depends on #2489