build: bundle devtools frontend #656
Open
+120
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/bundle-devtools
branch
5 times, most recently
from
e0b7b6b to
1cf4cd0
Compare
zyzyzyryxy
approved these changes
Dec 9, 2025
Contributor
zyzyzyryxy
left a comment
zyzyzyryxy
left a comment
There was a problem hiding this comment.
Great to see that bundled!
package.json
Outdated
| "test:update-snapshots": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-force-exit --test --test-update-snapshots \"build/tests/**/*.test.js\"", | ||
| "test:node20": "node --import ./build/tests/setup.js --test-reporter spec --test-force-exit --test build/tests", | ||
| "test:no-build": "node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --experimental-print-required-tla --test-reporter spec --test-force-exit --test \"build/tests/**/*.test.js\"", | ||
| "test": "npm run build && node --import ./build/tests/setup.js --no-warnings=ExperimentalWarning --experimental-print-required-tla --test-reporter spec --test-force-exit --test \"build/tests/**/*.test.js\"", |
Contributor
There was a problem hiding this comment.
Nit: Wouldn't it be better to have "test" run build then test:no-build to reduce duplication? Same for test:only
Collaborator
Author
There was a problem hiding this comment.
test:only can runs a slightly different command. We could probably spend time to figure how to forward extra args so that also -- forwarding keeps working. But I think it's fine for now. Changed test to run test:no-build.
Contributor
There was a problem hiding this comment.
I see test and test:only are different, I meant maybe test:only should call test:only:no-build. The commands are identical now, sans the build.
OrKoN
force-pushed
the
orkon/bundle-devtools
branch
from
1cf4cd0 to
ec8dc8d
Compare
OrKoN
force-pushed
the
orkon/bundle-devtools
branch
from
ec8dc8d to
2920887
Compare
OrKoN
force-pushed
the
orkon/bundle-devtools
branch
from
2920887 to
a2e1de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.