-
Notifications
You must be signed in to change notification settings - Fork 1
docs(XamlNavigation): Update Mvux XamlNavigation Docs with links to the appropriate YouTube tutorials #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
next part could be to show the csharp code way to do this or implementing the TabBar from the MvuxGallery app
chore: fix most of the docfx warnings, 17 left BUG: Uno.Resizetizer is getting shown as part of the API, which is not correct. BUG: Logo is not shown correctly, same as the video elements sourced from YouTube.
…ionApp-with-metadata
BUG: Still the landing page is not publishable as the topicHref is not working for this
Should resolve xml indentation issue
chore: change location of Navigation Intro
…eeded Will solve with copy pasting the appropriate code but should not be the target using docfx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enriches the XamlNavigationApp documentation by adding localized English and German tutorials with YouTube links, updates project and IDE launch configurations to support the new sample, and cleans up solution and package settings.
- Add
ReadMe.en.md
andReadMe.de.md
underXamlNavigationApp
with links to YouTube tutorials - Update
launchSettings.json
, VS Codetasks.json
/launch.json
, and solution to configure and debug the XamlNavigationApp - Extend documentation TOC, docfx settings, and remove the old
ReadMe.md
placeholder
Reviewed Changes
Copilot reviewed 71 out of 101 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/Directory.Packages.props | Remove stray trailing whitespace |
src/DevTKSS.Uno.XamlNavigationApp-1/ReadMe.* | Remove old ReadMe.md; add localized English/German docs with tutorial links |
src/DevTKSS.Uno.XamlNavigationApp-1/Properties/launchSettings.json | Fix commandLineArgs to point at the correct DLL |
src/DevTKSS.Uno.Samples.sln | Add Debug/Release configurations for x64 and x86 |
src/.vscode/tasks.json & src/.vscode/launch.json | Add build/publish tasks and launch configs for XamlNavigationApp |
doc/toc.yml & doc/articles/** | Update table-of-contents entries, metadata, and add new tutorial markdown files |
src/DevTKSS.Uno.Samples.MvuxGallery/Presentation/ViewModels/MainModel.cs | Add unused private field _stringLocalizer without constructor injection |
Comments suppressed due to low confidence (2)
src/DevTKSS.Uno.Samples.MvuxGallery/Presentation/ViewModels/MainModel.cs:5
- The
_stringLocalizer
field is declared but never assigned or used. Consider injecting it via the constructor or removing it if it's not needed.
private readonly IStringLocalizer _stringLocalizer;
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
WIP