Skip to content

[DYN-9230] Bump dynamo major version check for PackageManager. #16428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025
Merged

[DYN-9230] Bump dynamo major version check for PackageManager. #16428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f30712f
Bump version
reddyashish Jul 23, 2025
99dc5e4
Update PackageLoader.cs
reddyashish Jul 23, 2025
fdf5463
Update PackageManagerClientViewModel.cs
reddyashish Jul 23, 2025
2922ca6
Update PackageManagerClientViewModel.cs
reddyashish Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ internal async void ExecutePackageDownload(string name, PackageVersion package,
// also identify packages that have a dynamo engine version less than 3.x as a special case,
// as Dynamo 3.x uses .net8 and older versions used .net framework - these packages may not be compatible.
// This check will return empty if the current major version is not 3.
var preDYN3Deps = newPackageHeaders.Where(dep => dynamoVersion.Major == 3 && Version.Parse(dep.engine_version).Major < dynamoVersion.Major);
var preDYN4Deps = newPackageHeaders.Where(dep => dynamoVersion.Major == 4 && Version.Parse(dep.engine_version).Major < dynamoVersion.Major);

// If any of the required packages use a newer version of Dynamo, show a dialog to the user
// allowing them to cancel the package download
Expand All @@ -971,7 +971,7 @@ internal async void ExecutePackageDownload(string name, PackageVersion package,

//if any of the required packages use a pre 3.x version of Dynamo, show a dialog to the user
//allowing them to cancel the package download
if (preDYN3Deps.Any())
if (preDYN4Deps.Any())
{
var res = MessageBoxService.Show(ViewModelOwner,
$"{string.Format(Resources.MessagePackageOlderDynamo, DynamoViewModel.BrandingResourceProvider.ProductName)} {Resources.MessagePackOlderDynamoLink}",
Expand Down
2 changes: 1 addition & 1 deletion src/DynamoPackages/PackageLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ private void TryLoadPackageIntoLibrary(Package package)
Log($"Loaded Package {package.Name} {package.VersionName} from {package.RootDirectory}");
try
{
if (dynamoVersion.Major == 3 && Version.Parse(package.EngineVersion).Major < 3)
if (dynamoVersion.Major == 4 && Version.Parse(package.EngineVersion).Major < 3)
{
Log($@"{package.Name} {package.VersionName} has an engine version of {package.EngineVersion},
it may not be compatible with this version of Dynamo due to .NET runtime changes. ");
Expand Down
Loading