[DYN-9230] Bump dynamo major version check for PackageManager.

[reddyashish]

Purpose

https://jira.autodesk.com/browse/DYN-9230.

Bumping up the dynamo major check version to 4. Should fix the PackageManagerShowsWarningWhenDownloadingLegacyPackage test.

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB
• This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

[DYN-9230] Bump dynamo major version check for PackageManager.

Reviewers

@DynamoDS/eidos

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9230

[Copilot]

Pull Request Overview

This PR bumps the Dynamo major version check from 3 to 4 in package manager compatibility logic to align with the current Dynamo version. This change addresses compatibility warnings and test failures related to legacy package handling.

• Updated major version check from 3 to 4 in package loading logic
• Modified package download compatibility check to use version 4
• Updated variable name to reflect the new version check

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/DynamoPackages/PackageLoader.cs	Updates major version check in package loading compatibility logic
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs	Updates major version check and renames variable in package download logic

Comments suppressed due to low confidence (1)

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs:953

• [nitpick] The variable name 'preDYN4Deps' is misleading. Since this filters packages with engine version < 4, it should be named 'preDYN4Deps' to 'legacyDeps' or 'incompatibleDeps' to better reflect its purpose of identifying potentially incompatible legacy packages.

                    var preDYN4Deps = newPackageHeaders.Where(dep => dynamoVersion.Major == 4 && Version.Parse(dep.engine_version).Major < dynamoVersion.Major);

[reddyashish]

Failing test is unrelated and it is passing locally.