-
Notifications
You must be signed in to change notification settings - Fork 3.5k
RN 0.75 upgrade #45289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN 0.75 upgrade #45289
Conversation
…tch for android build
I saw some weird behavior on staging too. The App takes a long time to open the public room and then I saw three different behaviors:
|
It is already fixed in 14bab6a |
|
#45289 (comment) should be fixed with d679a18. Thanks @MrRefactor for help 🚀 |
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the last known issue is this so I think we could go ahead with this PR now
luacmartins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's get this party started
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.25-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.25-0 🚀
|
|
There seems no upstream issue for the |
|
There seems no upstream issue for the |
Details
PR with bumping App to RN 0.75 based on work with migrating to RN 0.74 and adding necessary changes.
PRs to affected libs:
react-native-share: fix: use proper way of deciding about new arch in podspec react-native-share/react-native-share#1563react-native-plaid-link-sdk: feat: add use_frameworks support plaid/react-native-plaid-link-sdk#701More patch info (copied from ultimately-never-merged RN 0.74 PR without verifying what changed between that PR and this one)
PATCHES:
Added/Changed:
@expensify+react-native-live-markdown+0.1.88.patch - link to upstream PR -> link
patches/expo-asset+10.0.9.patch - patch for Storybook to work
patches/react-native+0.74.2+010+Bridgeless.patch - disable bridgeless for both Android and iOS
patches/react-native+0.74.2+011+mapbufferjni.patch - link to upstream issue -> link
patches/react-native+0.74.2+014+invertedFlatList.patch - link to upstream PR - link
patches/react-native+0.74.2+015+nativeDriver.patch - link to upstream PR - link
patches/react-native-image-picker+7.0.3+001+allowedMimeTypes.patch - link to upstream PR - link
patches/react-native-vision-camera+4.0.0-beta.13.patch - link to upstream issue - link
patches/react-native-device-info+10.3.1+002+turbomodule.patch - link to upstream PR - link
patches/@react-native-community+netinfo+11.2.1+002+turbomodule.patch - link to upstream PR - link
patches/@onfido+react-native-sdk+10.6.0.patch - link to upstream PR - link
Removed:
patches/expo+50.0.4.patch
patches/expo-av+13.10.4.patch
patches/expo-modules-autolinking+1.10.2.patch
patches/expo-modules-core+1.11.8+001+initial.patch
patches/react-native+0.73.4+002+SuspenseFix.patch
patches/react-native+0.73.4+006+Codegen.patch
patches/react-native+0.73.4+011+optionalViewRecycling.patch
patches/react-native+0.73.4+013+exposePrefabs.patch
patches/react-native+0.73.4+014+fix-inverted-flatlist.patch
patches/react-native+0.73.4+014+fixPath.patch
patches/react-native+0.73.4+015+fixIOSWebViewCrash.patch
patches/react-native+0.73.4+016+iOS-textinput-onscroll-event.patch
patches/react-native-reanimated+3.7.2+001+fix-boost-dependency.patch
patches/react-native-reanimated+3.7.2+002+copy-state.patch
Fixed Issues
$ #43177
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop