Adjust workflows to properly run style on branches #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerkaraszewski
previously approved these changes
Dec 29, 2025
Contributor
Author
|
Can you do a small test, please? Can you create a branch based on this commit so we can test the internal pipeline? |
Contributor
Contributor
Author
|
Seems to be working properly now, right? |
Contributor
|
Looks like it is. @flodnv, want to review again? |
Open
flodnv
reviewed
Jan 5, 2026
Contributor
flodnv
left a comment
flodnv
left a comment
There was a problem hiding this comment.
Instead of mirroring what's in Auth, could we mirror what's in Web-E, which does not use is_fork?
Contributor
Author
Yep. In fact, I think it's way simpler, indeed. Let me know if that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently we have errors on the style pipeline for branches. It's only working for forks.
Fix the workflow taking auth as example
Fixed Issues
Fixes GH_LINK
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes