[HOLD] Adjust workflows to properly run style on branches #2429
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Use mirror.bastion1.sjc if running locally | ||
| APT_MIRROR_URL: "apt-mirror.expensify.com:843" | ||
| GITHUB_BRANCH: ${{ (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) && format('pull/{0}/head', github.event.pull_request.number) || github.ref_name }} | ||
| GITHUB_BRANCH: ${{ inputs.is_fork && format('pull/{0}/head', github.event.pull_request.number) || github.ref_name }} |
There was a problem hiding this comment.
Because this workflow now runs via workflow_call, the github.event payload is for the workflow_call event, not the original pull_request, so github.event.pull_request.number will be empty when bedrock-fork-trigger.yml calls it. With inputs.is_fork set, that makes GITHUB_BRANCH expand to something like pull//head, which breaks the ci_style.sh fetch/diff logic for forked PRs (invalid refspec). To keep forked style checks working, pass the PR number as an explicit input from the caller or derive it from github.ref instead of github.event.pull_request.
Useful? React with 👍 / 👎.
Details
Testing
Fixed Issues
Fixes GH_LINK
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes